refctor: 코드 리뷰 피드백 반영

Author: skybluesharkk

src/apis/notice/postFestivalNotice.ts

@@ -1,5 +1,5 @@
 import { apiInstance } from '@/apis/apiInstance';
-import type { NoticeCreateRequest } from '@/types/Notice';
+import type { NoticeRequest } from '@/types/Notice';
 import API_ENDPOINTS from '@/constants/apiEndpoints';
 import type { AxiosResponse } from 'axios';
 import { generatePath } from 'react-router-dom';
@@ -13,7 +13,7 @@ import { generatePath } from 'react-router-dom';
  */
 export const postFestivalNotice = async (
   festivalId: string,
-  noticeData: NoticeCreateRequest,
+  noticeData: NoticeRequest,
 ): Promise<AxiosResponse<void>> => {
   return await apiInstance.post<void>(
     generatePath(API_ENDPOINTS.FESTIVAL_NOTICE, { festivalId }),

src/apis/notice/putFestivalNotice.ts

@@ -2,7 +2,7 @@ import { apiInstance } from '@/apis/apiInstance';
 import API_ENDPOINTS from '@/constants/apiEndpoints';
 import { generatePath } from 'react-router-dom';
 import type { AxiosResponse } from 'axios';
-import type { NoticeUpdateRequest } from '@/types/Notice';
+import type { NoticeRequest } from '@/types/Notice';
 
 /**
  * 축제 공지사항 수정을 위한 API 함수입니다.
@@ -12,7 +12,7 @@ import type { NoticeUpdateRequest } from '@/types/Notice';
  */
 export const putFestivalNotice = async (
   id: string,
-  body: NoticeUpdateRequest,
+  body: NoticeRequest,
 ): Promise<AxiosResponse<void>> => {
   return await apiInstance.put<void>(
     generatePath(API_ENDPOINTS.FESTIVAL_NOTICE_DETAIL, { id }),

src/apis/review/deleteReview.ts

@@ -1,5 +1,6 @@
 import { apiInstance } from '@/apis/apiInstance';
 import API_ENDPOINTS from '@/constants/apiEndpoints';
+import { generatePath } from 'react-router-dom';
 
 /**
  * 리뷰 삭제를 위한 함수
@@ -8,7 +9,7 @@ import API_ENDPOINTS from '@/constants/apiEndpoints';
  */
 export const deleteReview = async (reviewId: number) => {
   const response = await apiInstance.delete(
-    API_ENDPOINTS.REVIEW_DELETE.replace(':reviewId', reviewId.toString()),
+    generatePath(API_ENDPOINTS.REVIEW_BY_ID, { reviewId: reviewId.toString() }),
   );
   return response.data;
 };

src/apis/review/getSingleReview.ts

@@ -10,7 +10,7 @@ export const getSingleReview = async (
   reviewId: number,
 ): Promise<AxiosResponse<ApiResponseItem<Review>, ApiErrorResponse>> => {
   return await apiInstance.get<ApiResponseItem<Review>>(
-    generatePath(API_ENDPOINTS.REVIEW_SINGLE, { reviewId: reviewId.toString() }),
+    generatePath(API_ENDPOINTS.REVIEW_BY_ID, { reviewId: reviewId.toString() }),
   );
 };
 

src/apis/review/putReview.ts

@@ -1,6 +1,7 @@
 import { apiInstance } from '@/apis/apiInstance';
 import API_ENDPOINTS from '@/constants/apiEndpoints';
 import type { MediaInfo } from '@/types/Media/MediaInfo';
+import { generatePath } from 'react-router-dom';
 
 export interface ReviewUpdateRequest {
   content: string;
@@ -11,7 +12,7 @@ export interface ReviewUpdateRequest {
 
 export const putReview = async (reviewId: number, body: ReviewUpdateRequest) => {
   return await apiInstance.put(
-    API_ENDPOINTS.REVIEW_UPDATE.replace(':reviewId', reviewId.toString()),
+    generatePath(API_ENDPOINTS.REVIEW_BY_ID, { reviewId: reviewId.toString() }),
     body,
   );
 };

src/components/form/TextInputWithCounter.tsx

@@ -11,6 +11,7 @@ interface TextInputWithCounterProps {
   showMinLengthMessage?: boolean;
   minLengthMessage?: string;
   errorClassName?: string;
+  name?: string;
 }
 /**
  * TextInputWithCounter 컴포넌트
@@ -37,6 +38,7 @@ const TextInputWithCounter = ({
   rows = 1,
   showMinLengthMessage = false,
   errorClassName = 'text-red-500',
+  name,
 }: TextInputWithCounterProps) => {
   const isMinLengthError = minLength && value.length < minLength;
   const isMaxLengthError = value.length > maxLength;
@@ -45,6 +47,7 @@ const TextInputWithCounter = ({
     <div className="mb-4">
       {type === 'input' ? (
         <input
+          name={name}
           type="text"
           value={value}
           onChange={onChange}
@@ -55,6 +58,7 @@ const TextInputWithCounter = ({
         />
       ) : (
         <textarea
+          name={name}
           value={value}
           onChange={onChange}
           placeholder={placeholder}

src/constants/apiEndpoints.ts

@@ -25,12 +25,8 @@ const API_ENDPOINTS = {
   DELETE_USER: '/api/users',
   // 내가 작성한 리뷰
   MY_REVIEWS: '/api/reviews/my',
-  // 리뷰 삭제
-  REVIEW_DELETE: '/api/reviews/:reviewId',
-  // 리뷰 수정
-  REVIEW_UPDATE: '/api/reviews/:reviewId',
-  // 리뷰 단건 조회
-  REVIEW_SINGLE: '/api/reviews/:reviewId',
+  // 리뷰 (조회/수정/삭제)
+  REVIEW_BY_ID: '/api/reviews/:reviewId',
   // 미디어 업로드
   PRESIGNED_URL: '/api/presigned-url',
   // 축제 관리자 신청

src/pages/FestivalInfoNoticeCreate/components/FestivalInfoNoticeForm.tsx

@@ -2,7 +2,7 @@ import { generatePath } from 'react-router-dom';
 import { useMutation } from '@tanstack/react-query';
 import { postFestivalNotice } from '@/apis/notice/postFestivalNotice';
 import FormSubmitButtons from '@/components/common/FormSubmitButtons';
-import type { NoticeCreateRequest } from '@/types/Notice';
+import type { NoticeRequest } from '@/types/Notice';
 import FestivalInfoNoticeRuleCard from '@/pages/FestivalInfoNoticeCreate/components/FestivalInfoNoticeRuleCard';
 import useNav from '@/hooks/useNav';
 import { useMediaUpload } from '@/hooks/useMediaUpload';
@@ -33,7 +33,7 @@ const FestivalInfoNoticeForm = ({ festivalData }: { festivalData: FestivalInfo }
   });
 
   const { mutate: submitApplication, isPending } = useMutation({
-    mutationFn: (body: NoticeCreateRequest) => postFestivalNotice(festivalData.id.toString(), body),
+    mutationFn: (body: NoticeRequest) => postFestivalNotice(festivalData.id.toString(), body),
     onSuccess: () => {
       queryClient.invalidateQueries({ queryKey: ['festival-notices'] });
       showToastSuccessMessage('공지사항이 작성되었습니다.');

src/pages/FestivalInfoNoticeEdit/components/FestivalInfoNoticeEditForm.tsx

@@ -2,7 +2,7 @@ import { generatePath, useNavigate } from 'react-router-dom';
 import { useMutation } from '@tanstack/react-query';
 import { putFestivalNotice } from '@/apis/notice/putFestivalNotice';
 import FormSubmitButtons from '@/components/common/FormSubmitButtons';
-import type { NoticeUpdateRequest } from '@/types/Notice';
+import type { NoticeRequest } from '@/types/Notice';
 import FestivalInfoNoticeRuleCard from '@/pages/FestivalInfoNoticeCreate/components/FestivalInfoNoticeRuleCard';
 import useNav from '@/hooks/useNav';
 import { useMediaUpload } from '@/hooks/useMediaUpload';
@@ -57,7 +57,7 @@ const FestivalInfoNoticeEditForm = ({
   }, [noticeData.images, setImageInfos]);
 
   const { mutate: submitApplication, isPending } = useMutation({
-    mutationFn: (body: NoticeUpdateRequest) => putFestivalNotice(noticeId, body),
+    mutationFn: (body: NoticeRequest) => putFestivalNotice(noticeId, body),
     onSuccess: () => {
       // 관련 쿼리들 무효화
       queryClient.invalidateQueries({ queryKey: ['festival-notices'] });
@@ -100,6 +100,7 @@ const FestivalInfoNoticeEditForm = ({
         <h3 className="font-semibold mb-3">아래 빈칸을 모두 작성해주세요.</h3>
 
         <TextInputWithCounter
+          name="title"
           value={title}
           onChange={(e) => setTitle(e.target.value)}
           placeholder="공지사항 제목을 입력하세요"
@@ -115,6 +116,7 @@ const FestivalInfoNoticeEditForm = ({
         />
 
         <TextInputWithCounter
+          name="content"
           value={content}
           onChange={(e) => setContent(e.target.value)}
           placeholder="공지사항 내용을 입력하세요"

src/pages/FestivalInfoNoticeList/FestivalInfoNoticeListPage.tsx

@@ -14,7 +14,7 @@ import getFestivalInfo from '@/apis/festivals/getFestivalInfo';
 import FestivalInfoNoticeListInfoCard from '@/pages/FestivalInfoNoticeList/components/FestivalInfoNoticeListInfoCard';
 import { deleteFestivalNotice } from '@/apis/notice/deleteFestivalNotice';
 import ConfirmModal from '@/components/modal/ConfirmModal';
-import { FestivalInfoNoticeCard } from './components/FestivalInfoNoticeCard';
+import { FestivalInfoNoticeCard } from '@/pages/FestivalInfoNoticeList/components/FestivalInfoNoticeCard';
 import { useDeleteWithConfirm } from '@/hooks/useDeleteWithConfirm';
 import { useNoticeNavigationHandlers } from '@/hooks/useNoticeNavigationHandlers';