Skip to content

Commit 5fc6a6a

Browse files
committed
refactor: 헬스체크, 다중컬렉션 left 조인 제거
1 parent 7e4747e commit 5fc6a6a

4 files changed

Lines changed: 15 additions & 3 deletions

File tree

docker-compose.qa.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,12 @@ services:
7777
- pullit-qa-network
7878
image: ${DOCKER_IMAGE_BLUE}
7979
container_name: pullit-qa-worker-blue
80+
healthcheck:
81+
test: ["CMD", "wget", "--no-verbose", "--tries=1", "--spider", "http://localhost:8080/actuator/health"]
82+
interval: 30s
83+
timeout: 10s
84+
retries: 5
85+
start_period: 90s
8086
environment:
8187
<<: *pullit-common-env
8288
SPRING_PROFILES_ACTIVE: qa,worker
@@ -94,6 +100,12 @@ services:
94100
- pullit-qa-network
95101
image: ${DOCKER_IMAGE_GREEN}
96102
container_name: pullit-qa-worker-green
103+
healthcheck:
104+
test: ["CMD", "wget", "--no-verbose", "--tries=1", "--spider", "http://localhost:8080/actuator/health"]
105+
interval: 30s
106+
timeout: 10s
107+
retries: 5
108+
start_period: 90s
97109
environment:
98110
<<: *pullit-common-env
99111
SPRING_PROFILES_ACTIVE: qa,worker

src/main/java/kr/it/pullit/modules/learningsource/source/exception/S3FileNotFoundForSourceException.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ private S3FileNotFoundForSourceException(Object... args) {
1010

1111
public static S3FileNotFoundForSourceException bySourceIdAndFilePath(
1212
Long sourceId, String filePath) {
13-
return new S3FileNotFoundForSourceException(
14-
"S3에 파일이 존재하지 않습니다. (sourceId: %d, filePath: '%s')", sourceId, filePath);
13+
return new S3FileNotFoundForSourceException(sourceId, filePath);
1514
}
1615
}

src/main/java/kr/it/pullit/modules/questionset/domain/entity/QuestionSet.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
import lombok.Getter;
3636
import lombok.NoArgsConstructor;
3737
import lombok.Setter;
38+
import org.hibernate.annotations.BatchSize;
3839
import org.hibernate.annotations.SQLDelete;
3940
import org.hibernate.annotations.SQLRestriction;
4041

@@ -71,6 +72,7 @@ public class QuestionSet extends BaseEntity {
7172
name = "question_set_source",
7273
joinColumns = @JoinColumn(name = "question_set_id"),
7374
inverseJoinColumns = @JoinColumn(name = "source_id"))
75+
@BatchSize(size = 100)
7476
private Set<Source> sources = new HashSet<>();
7577

7678
// TODO: 리팩토링 대상 타이틀 정책이 빈약함.

src/main/java/kr/it/pullit/modules/questionset/repository/adapter/jpa/QuestionSetJpaRepository.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ List<QuestionSet> findByStatusAndCreatedAtBefore(
5555
SELECT qs
5656
FROM QuestionSet qs
5757
LEFT JOIN FETCH qs.questions
58-
LEFT JOIN FETCH qs.sources
5958
WHERE qs.id = :id
6059
AND qs.ownerId = :memberId
6160
AND qs.status = 'COMPLETE'

0 commit comments

Comments
 (0)