Move ensureIncompleteTexturesCreated() to ContextMtl::syncState()

kakashidinho · kakashidinho · commit 16c8f7991bf9 · 2020-04-18T06:59:11.000+08:00
Change-Id: Ibf986f889797a21f1cbc8c412c30d5d84fc77933
diff --git a/src/libANGLE/renderer/metal/ContextMtl.mm b/src/libANGLE/renderer/metal/ContextMtl.mm
@@ -753,6 +753,9 @@ bool NeedToInvertDepthRange(float near, float far)
 {
     const gl::State &glState = context->getState();
 
+    // Initialize incomplete texture set.
+    ANGLE_TRY(ensureIncompleteTexturesCreated(context));
+
     for (size_t dirtyBit : dirtyBits)
     {
         switch (dirtyBit)
@@ -1721,9 +1724,6 @@ bool NeedToInvertDepthRange(float near, float far)
     // instances=0 means no instanced draw.
     GLsizei instanceCount = instances ? instances : 1;
 
-    // Must be called before the render command encoder is started.
-    ANGLE_TRY(ensureIncompleteTexturesCreated(context));
-
     if (context->getStateCache().hasAnyActiveClientAttrib())
     {
         ANGLE_TRY(mVertexArray->updateClientAttribs(context, firstVertex, vertexOrIndexCount,

Original file line number	Diff line number	Diff line change
`@@ -753,6 +753,9 @@ bool NeedToInvertDepthRange(float near, float far)`
`753`	`753`	`{`
`754`	`754`	`const gl::State &glState = context->getState();`
`755`	`755`
	`756`	`+ // Initialize incomplete texture set.`
	`757`	`+ ANGLE_TRY(ensureIncompleteTexturesCreated(context));`
	`758`	`+`
`756`	`759`	`for (size_t dirtyBit : dirtyBits)`
`757`	`760`	`{`
`758`	`761`	`switch (dirtyBit)`
`@@ -1721,9 +1724,6 @@ bool NeedToInvertDepthRange(float near, float far)`
`1721`	`1724`	`// instances=0 means no instanced draw.`
`1722`	`1725`	`GLsizei instanceCount = instances ? instances : 1;`
`1723`	`1726`
`1724`		`- // Must be called before the render command encoder is started.`
`1725`		`- ANGLE_TRY(ensureIncompleteTexturesCreated(context));`
`1726`		`-`
`1727`	`1727`	`if (context->getStateCache().hasAnyActiveClientAttrib())`
`1728`	`1728`	`{`
`1729`	`1729`	`ANGLE_TRY(mVertexArray->updateClientAttribs(context, firstVertex, vertexOrIndexCount,`