Modify code to conform to ShellCheck specifications

Author: sendream

egs/xbmu_amdo31/s5/cmd.sh

@@ -10,6 +10,6 @@
 # conf/queue.conf in http://kaldi-asr.org/doc/queue.html for more information,
 # or search for the string 'default_config' in utils/queue.pl or utils/slurm.pl.
 
-export train_cmd=run.pl
-export decode_cmd=run.pl
-export mkgraph_cmd=run.pl
+export train_cmd="queue.pl --mem 2G"
+export decode_cmd="queue.pl --mem 4G"
+export mkgraph_cmd="queue.pl --mem 8G"

egs/xbmu_amdo31/s5/local/chain/tuning/run_tdnn_1a.sh

@@ -27,7 +27,7 @@ common_egs_dir=
 xent_regularize=0.1
 
 # End configuration section.
-echo "$0 $@"  # Print the command line for logging
+echo "$0 $*"  # Print the command line for logging
 
 . ./cmd.sh
 . ./path.sh

egs/xbmu_amdo31/s5/local/chain/tuning/run_tdnn_2a.sh

@@ -29,7 +29,7 @@ common_egs_dir=
 xent_regularize=0.1
 
 # End configuration section.
-echo "$0 $@"  # Print the command line for logging
+echo "$0 $*"  # Print the command line for logging
 
 . ./cmd.sh
 . ./path.sh

egs/xbmu_amdo31/s5/local/nnet3/run_ivector_common.sh

@@ -90,7 +90,7 @@ if [ $stage -le 4 ]; then
   temp_data_root=exp/nnet3${nnet3_affix}/diag_ubm
 
   num_utts_total=$(wc -l <data/${train_set}_sp_hires_nopitch/utt2spk)
-  num_utts=$[$num_utts_total/4]
+  num_utts=$((num_utts_total/4))
   utils/data/subset_data_dir.sh data/${train_set}_sp_hires_nopitch \
      $num_utts ${temp_data_root}/${train_set}_sp_hires_nopitch_subset
 

egs/xbmu_amdo31/s5/local/nnet3/tuning/run_tdnn_1a.sh

@@ -105,7 +105,7 @@ if [ $stage -le 9 ]; then
   # this version of the decoding treats each utterance separately
   # without carrying forward speaker information.
   for decode_set in dev test; do
-    num_jobs=`cat data/${decode_set}_hires/utt2spk|cut -d' ' -f2|sort -u|wc -l`
+    num_jobs=$(cat data/${decode_set}_hires/utt2spk|cut -d' ' -f2|sort -u|wc -l)
     decode_dir=${dir}/decode_$decode_set
     steps/nnet3/decode.sh --nj $num_jobs --cmd "$decode_cmd" \
        --online-ivector-dir exp/nnet3/ivectors_${decode_set} \

egs/xbmu_amdo31/s5/local/nnet3/tuning/run_tdnn_2a.sh

@@ -103,7 +103,7 @@ if [ $stage -le 9 ]; then
   # this version of the decoding treats each utterance separately
   # without carrying forward speaker information.
   for decode_set in dev test; do
-    num_jobs=`cat data/${decode_set}_hires_online/utt2spk|cut -d' ' -f2|sort -u|wc -l`
+    num_jobs=$(cat data/${decode_set}_hires_online/utt2spk|cut -d' ' -f2|sort -u|wc -l)
     decode_dir=${dir}/decode_$decode_set
     steps/nnet3/decode.sh --nj $num_jobs --cmd "$decode_cmd" \
        --online-ivector-dir exp/nnet3/ivectors_${decode_set} \
@@ -121,7 +121,8 @@ if [ $stage -le 11 ]; then
   # do the actual online decoding with iVectors, carrying info forward from
   # previous utterances of the same speaker.
   for decode_set in dev test; do
-    num_jobs=`cat data/${decode_set}_hires_online/utt2spk|cut -d' ' -f2|sort -u|wc -l`
+    # num_jobs=`cat data/${decode_set}_hires_online/utt2spk|cut -d' ' -f2|sort -u|wc -l`
+    num_jobs=$(cat "data/${decode_set}_hires_online/utt2spk" | cut -d' ' -f2 | sort -u | wc -l)
     decode_dir=${dir}_online/decode_$decode_set
     steps/online/nnet3/decode.sh --nj $num_jobs --cmd "$decode_cmd" \
        --config conf/decode.config \
@@ -133,7 +134,8 @@ if [ $stage -le 12 ]; then
   # this version of the decoding treats each utterance separately
   # without carrying forward speaker information.
   for decode_set in dev test; do
-    num_jobs=`cat data/${decode_set}_hires_online/utt2spk|cut -d' ' -f2|sort -u|wc -l`
+    # num_jobs=`cat data/${decode_set}_hires_online/utt2spk|cut -d' ' -f2|sort -u|wc -l`
+    num_jobs=$(cat "data/${decode_set}_hires_online/utt2spk" | cut -d' ' -f2 | sort -u | wc -l)
     decode_dir=${dir}_online/decode_${decode_set}_per_utt
     steps/online/nnet3/decode.sh --nj $num_jobs --cmd "$decode_cmd" \
        --config conf/decode.config --per-utt true \

egs/xbmu_amdo31/s5/local/xbmu_amdo31_data_prep.sh

@@ -33,7 +33,7 @@ fi
 echo $tibetan_audio_dir
 # find wav audio file for train, dev and test resp.
 find $tibetan_audio_dir -iname "*.wav" > $tmp_dir/wav.flist
-n=`cat $tmp_dir/wav.flist | wc -l`
+n=$(wc -l < "$tmp_dir/wav.flist")
 [ $n -ne 22630 ] && \
   echo Warning: expected 141925 data data files, found $n
 
@@ -49,13 +49,13 @@ for dir in $train_dir $dev_dir $test_dir; do
   sed -e 's/\.wav//' $dir/wav.flist | awk -F '/' '{print $NF}'  > $dir/utt.list
   sed -e 's/\.wav//' $dir/wav.flist | awk -F '/' '{i=NF-1;printf("%s %s\n",$NF,$i)}'> $dir/utt2spk_all
   rm -f $dir/transcripts1.txt
-  cat $dir/utt.list |while read line
+  while read -r line
   do
-      line1=`echo $line |cut -d "-" -f 2`
-      line2=`grep -w $line1  $tibetan_text |cut -d " " -f 2-`
+      line1=$(echo "$line" | cut -d '-' -f 2)
+      line2=$(grep -w $line1  $tibetan_text |cut -d " " -f 2-)
       text=$line" "$line2
       echo $text >>$dir/transcripts1.txt
-  done
+  done < "$dir/utt.list"
   paste -d' ' $dir/utt.list $dir/wav.flist > $dir/wav.scp_all
   utils/filter_scp.pl -f 1 $dir/utt.list $dir/transcripts1.txt > $dir/transcripts.txt
   awk '{print $1}' $dir/transcripts.txt > $dir/utt.list

egs/xbmu_amdo31/s5/local/xbmu_amdo31_train_lms.sh

@@ -19,7 +19,7 @@ done
 dir=data/local/lm
 mkdir -p $dir
 
-kaldi_lm=`which train_lm.sh`
+kaldi_lm=$(command -v train_lm.sh)
 if [ -z $kaldi_lm ]; then
   echo "$0: train_lm.sh is not found. That might mean it's not installed"
   echo "$0: or it is not added to PATH"

egs/xbmu_amdo31/s5/path.sh

@@ -1,4 +1,4 @@
-export KALDI_ROOT=`pwd`/../../..
+export KALDI_ROOT=$(pwd)/../../..
 [ -f $KALDI_ROOT/tools/env.sh ] && . $KALDI_ROOT/tools/env.sh
 export PATH=$PWD/utils/:$KALDI_ROOT/tools/openfst/bin:$PWD:$PATH
 [ ! -f $KALDI_ROOT/tools/config/common_path.sh ] && echo >&2 "The standard file $KALDI_ROOT/tools/config/common_path.sh is not present -> Exit!" && exit 1