Better erro messages when a user has an empty email from ldap

Author: Gaetano Giunta

Adapter/LDAP/RemoteUser.php

@@ -41,11 +41,13 @@ public function getRoles()
     }
 
     /**
-     * @todo throw if unset ?
      * @return string
      */
     public function getEmail()
     {
+        if (!isset($this->profile[$this->emailField])) {
+            throw new \RuntimeException("User account misses or has empty email (from ldap profile field '{$this->emailField}')");
+        }
         return $this->profile[$this->emailField];
     }
 

Security/User/Provider/RemoteUser.php

@@ -108,7 +108,7 @@ public function loadAPIUserByRemoteUser(KaliopRemoteUser $remoteUser)
             }
 
         } catch (\Exception $e) {
-            if ($this->logger) $this->logger->error("Unexpected error while finding/creating/updating repo user from data gotten from remote service");
+            if ($this->logger) $this->logger->error("Unexpected error while finding/creating/updating repo user from data gotten from remote service: " . $e->getMessage());
             throw $e;
         }