Fix Attempt to assign property "custommenuitems" on null error

lucaboesch · lucaboesch · commit 3d005c7f5a60 · 2024-02-05T18:39:06.000+01:00
diff --git a/local/mymedia/lib.php b/local/mymedia/lib.php
@@ -74,5 +74,7 @@ function local_mymedia_extend_navigation($navigation) {
     }
 
     $myMediaStr = "\n$menuHeaderStr|/local/mymedia/mymedia.php";
-    $CFG->custommenuitems .= $myMediaStr;
+    if (empty($custommenuitems) && (isset($CFG->custommenuitems) && !empty($CFG->custommenuitems))) {
+        $CFG->custommenuitems .= $myMediaStr;
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -74,5 +74,7 @@ function local_mymedia_extend_navigation($navigation) {`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`$myMediaStr = "\n$menuHeaderStr\|/local/mymedia/mymedia.php";`
`77`		`- $CFG->custommenuitems .= $myMediaStr;`
	`77`	`+ if (empty($custommenuitems) && (isset($CFG->custommenuitems) && !empty($CFG->custommenuitems))) {`
	`78`	`+ $CFG->custommenuitems .= $myMediaStr;`
	`79`	`+ }`
`78`	`80`	`}`