Skip to content

Failing plugin_checks_test::test_db_install_file tests #473

@ctam

Description

@ctam

With the introduction of core\db\plugin_checks_test::test_db_install_file in MDL-85666, we might need to update the install.xml file for this test to pass.

core\db\plugin_checks_test::test_db_install_file with data set "mod_kalvidassign" ('mod_kalvidassign', 'mod', 'kalvidassign', '/home/runner/work/moodle/mood...assign')
XMLDB structure does not match the install.xml file in /home/runner/work/moodle/moodle/mod/kalvidassign/db/install.xml
Failed asserting that two DOM documents are equal.
--- Expected
+++ Actual
@@ @@
 <?xml version="1.0"?>
 <XMLDB xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" COMMENT="XMLDB file for Moodle mod/kalvidassign" PATH="mod/kalvidassign/db" VERSION="2024042202" xsi:noNamespaceSchemaLocation="../../../lib/xmldb/xmldb.xsd">
   <TABLES>
-    <TABLE COMMENT="Kaltura video assignment module instances are stored here" NAME="kalvidassign" NEXT="kalvidassign_submission">
+    <TABLE COMMENT="Kaltura video assignment module instances are stored here" NAME="kalvidassign">
       <FIELDS>
-        <FIELD LENGTH="10" NAME="id" NEXT="course" NOTNULL="true" SEQUENCE="true" TYPE="int" UNSIGNED="true"/>
-        <FIELD COMMENT="Course id" DEFAULT="0" LENGTH="10" NAME="course" NEXT="name" NOTNULL="true" PREVIOUS="id" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
-        <FIELD LENGTH="255" NAME="name" NEXT="intro" NOTNULL="true" PREVIOUS="course" SEQUENCE="false" TYPE="char"/>
-        <FIELD LENGTH="small" NAME="intro" NEXT="introformat" NOTNULL="false" PREVIOUS="name" SEQUENCE="false" TYPE="text"/>
-        <FIELD DEFAULT="0" LENGTH="4" NAME="introformat" NEXT="timeavailable" NOTNULL="true" PREVIOUS="intro" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
-        <FIELD COMMENT="Time the assignment is available for student submission" DEFAULT="0" LENGTH="10" NAME="timeavailable" NEXT="timedue" NOTNULL="true" PREVIOUS="introformat" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
-        <FIELD COMMENT="The time the assignment submissions are due by" DEFAULT="0" LENGTH="10" NAME="timedue" NEXT="preventlate" NOTNULL="true" PREVIOUS="timeavailable" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
-        <FIELD COMMENT="Prevent late submissions" DEFAULT="0" LENGTH="1" NAME="preventlate" NEXT="resubmit" NOTNULL="true" PREVIOUS="timedue" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
-        <FIELD COMMENT="Allow for resubmissions" DEFAULT="0" LENGTH="1" NAME="resubmit" NEXT="emailteachers" NOTNULL="true" PREVIOUS="preventlate" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
-        <FIELD COMMENT="Email submissions to the teacher" DEFAULT="0" LENGTH="1" NAME="emailteachers" NEXT="grade" NOTNULL="true" PREVIOUS="resubmit" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
-        <FIELD COMMENT="Maximum grade the assignment is worth" DEFAULT="0" LENGTH="10" NAME="grade" NEXT="timecreated" NOTNULL="true" PREVIOUS="emailteachers" SEQUENCE="false" TYPE="int" UNSIGNED="false"/>
-        <FIELD COMMENT="Time the assignment was created" DEFAULT="0" LENGTH="10" NAME="timecreated" NEXT="timemodified" NOTNULL="true" PREVIOUS="emailteachers" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
-        <FIELD COMMENT="The time the assignment settings were modified" DEFAULT="0" LENGTH="10" NAME="timemodified" NOTNULL="true" PREVIOUS="timecreated" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
-        <FIELD COMMENT="If this field is set to 1, then the activity will be automatically marked as 'complete' once the user submits their assignment." DEFAULT="0" LENGTH="2" NAME="completionsubmit" NOTNULL="true" PREVIOUS="timemodified" SEQUENCE="false" TYPE="int"/>
+        <FIELD LENGTH="10" NAME="id" NOTNULL="true" SEQUENCE="true" TYPE="int"/>
+        <FIELD COMMENT="Course id" DEFAULT="0" LENGTH="10" NAME="course" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD LENGTH="255" NAME="name" NOTNULL="true" SEQUENCE="false" TYPE="char"/>
+        <FIELD NAME="intro" NOTNULL="false" SEQUENCE="false" TYPE="text"/>
+        <FIELD DEFAULT="0" LENGTH="4" NAME="introformat" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Time the assignment is available for student submission" DEFAULT="0" LENGTH="10" NAME="timeavailable" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="The time the assignment submissions are due by" DEFAULT="0" LENGTH="10" NAME="timedue" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Prevent late submissions" DEFAULT="0" LENGTH="1" NAME="preventlate" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Allow for resubmissions" DEFAULT="0" LENGTH="1" NAME="resubmit" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Email submissions to the teacher" DEFAULT="0" LENGTH="1" NAME="emailteachers" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Maximum grade the assignment is worth" DEFAULT="0" LENGTH="10" NAME="grade" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Time the assignment was created" DEFAULT="0" LENGTH="10" NAME="timecreated" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="The time the assignment settings were modified" DEFAULT="0" LENGTH="10" NAME="timemodified" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="If this field is set to 1, then the activity will be automatically marked as 'complete' once the user submits their assignment." DEFAULT="0" LENGTH="2" NAME="completionsubmit" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
       </FIELDS>
       <KEYS>
         <KEY FIELDS="id" NAME="primary" TYPE="primary"/>
@@ @@
         <INDEX COMMENT="index on course" FIELDS="course" NAME="kal_course_idx" UNIQUE="false"/>
       </INDEXES>
     </TABLE>
-    <TABLE COMMENT="Kaltura video assignment submissions" NAME="kalvidassign_submission" PREVIOUS="kalvidassign">
+    <TABLE COMMENT="Kaltura video assignment submissions" NAME="kalvidassign_submission">
       <FIELDS>
-        <FIELD LENGTH="10" NAME="id" NEXT="vidassignid" NOTNULL="true" SEQUENCE="true" TYPE="int" UNSIGNED="true"/>
-        <FIELD COMMENT="Foreign key to the kalvidassign table" DEFAULT="0" LENGTH="10" NAME="vidassignid" NEXT="userid" NOTNULL="true" PREVIOUS="id" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
-        <FIELD COMMENT="Moodle user id" DEFAULT="0" LENGTH="10" NAME="userid" NEXT="entry_id" NOTNULL="true" PREVIOUS="vidassignid" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
-        <FIELD COMMENT="Kaltura entry id" LENGTH="50" NAME="entry_id" NEXT="source" NOTNULL="true" PREVIOUS="userid" SEQUENCE="false" TYPE="char"/>
-        <FIELD COMMENT="The source URL of the media entry." NAME="source" NEXT="width" NOTNULL="false" PREVIOUS="entry_id" SEQUENCE="false" TYPE="text"/>
-        <FIELD COMMENT="Iframe width." DEFAULT="0" LENGTH="10" NAME="width" NEXT="height" NOTNULL="false" PREVIOUS="source" SEQUENCE="false" TYPE="int"/>
-        <FIELD COMMENT="Iframe height." DEFAULT="0" LENGTH="10" NAME="height" NEXT="grade" NOTNULL="false" PREVIOUS="width" SEQUENCE="false" TYPE="int"/>
-        <FIELD COMMENT="Grade score for the submission" DEFAULT="0" LENGTH="11" NAME="grade" NEXT="submissioncomment" NOTNULL="true" PREVIOUS="height" SEQUENCE="false" TYPE="int" UNSIGNED="false"/>
-        <FIELD COMMENT="Submission teacher comment" LENGTH="medium" NAME="submissioncomment" NEXT="format" NOTNULL="false" PREVIOUS="grade" SEQUENCE="false" TYPE="text"/>
-        <FIELD DEFAULT="0" LENGTH="4" NAME="format" NEXT="teacher" NOTNULL="true" PREVIOUS="submissioncomment" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
-        <FIELD COMMENT="Moodle userId of the teacher who marked the submission" DEFAULT="0" LENGTH="10" NAME="teacher" NEXT="mailed" NOTNULL="true" PREVIOUS="format" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
-        <FIELD COMMENT="Whether the assignment submission notification has been emailed to the teacher." DEFAULT="0" LENGTH="1" NAME="mailed" NEXT="timemarked" NOTNULL="true" PREVIOUS="teacher" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
-        <FIELD COMMENT="Time the assignment submission was marked" DEFAULT="0" LENGTH="10" NAME="timemarked" NEXT="metadata" NOTNULL="true" PREVIOUS="mailed" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
-        <FIELD COMMENT="Stores a base 64 encoded serialized metadata object." NAME="metadata" NEXT="timecreated" NOTNULL="false" PREVIOUS="timemarked" SEQUENCE="false" TYPE="text"/>
-        <FIELD COMMENT="Time the submission record was created" DEFAULT="0" LENGTH="10" NAME="timecreated" NEXT="timemodified" NOTNULL="true" PREVIOUS="metadata" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
-        <FIELD COMMENT="Time the assignment submission was modified" DEFAULT="0" LENGTH="10" NAME="timemodified" NOTNULL="true" PREVIOUS="timecreated" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
+        <FIELD LENGTH="10" NAME="id" NOTNULL="true" SEQUENCE="true" TYPE="int"/>
+        <FIELD COMMENT="Foreign key to the kalvidassign table" DEFAULT="0" LENGTH="10" NAME="vidassignid" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Moodle user id" DEFAULT="0" LENGTH="10" NAME="userid" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Kaltura entry id" LENGTH="50" NAME="entry_id" NOTNULL="true" SEQUENCE="false" TYPE="char"/>
+        <FIELD COMMENT="The source URL of the media entry." NAME="source" NOTNULL="false" SEQUENCE="false" TYPE="text"/>
+        <FIELD COMMENT="Iframe width." DEFAULT="0" LENGTH="10" NAME="width" NOTNULL="false" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Iframe height." DEFAULT="0" LENGTH="10" NAME="height" NOTNULL="false" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Grade score for the submission" DEFAULT="0" LENGTH="11" NAME="grade" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Submission teacher comment" NAME="submissioncomment" NOTNULL="false" SEQUENCE="false" TYPE="text"/>
+        <FIELD DEFAULT="0" LENGTH="4" NAME="format" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Moodle userId of the teacher who marked the submission" DEFAULT="0" LENGTH="10" NAME="teacher" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Whether the assignment submission notification has been emailed to the teacher." DEFAULT="0" LENGTH="1" NAME="mailed" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Time the assignment submission was marked" DEFAULT="0" LENGTH="10" NAME="timemarked" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Stores a base 64 encoded serialized metadata object." NAME="metadata" NOTNULL="false" SEQUENCE="false" TYPE="text"/>
+        <FIELD COMMENT="Time the submission record was created" DEFAULT="0" LENGTH="10" NAME="timecreated" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Time the assignment submission was modified" DEFAULT="0" LENGTH="10" NAME="timemodified" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
       </FIELDS>
       <KEYS>
         <KEY FIELDS="id" NAME="primary" TYPE="primary"/>
       </KEYS>
       <INDEXES>
-        <INDEX COMMENT="Index on the kaltura assignment id" FIELDS="vidassignid" NAME="kal_vid_assign_idx" NEXT="kal_userid_idx" UNIQUE="false"/>
-        <INDEX COMMENT="Index on the Moodle userid" FIELDS="userid" NAME="kal_userid_idx" NEXT="kal_marked_idx" PREVIOUS="kal_vid_assign_idx" UNIQUE="false"/>
-        <INDEX COMMENT="Index on the submission marked field" FIELDS="timemarked" NAME="kal_marked_idx" NEXT="kal_mailed_idx" PREVIOUS="kal_userid_idx" UNIQUE="false"/>
-        <INDEX COMMENT="Index on the mailed field" FIELDS="mailed" NAME="kal_mailed_idx" PREVIOUS="kal_marked_idx" UNIQUE="false"/>
+        <INDEX COMMENT="Index on the kaltura assignment id" FIELDS="vidassignid" NAME="kal_vid_assign_idx" UNIQUE="false"/>
+        <INDEX COMMENT="Index on the Moodle userid" FIELDS="userid" NAME="kal_userid_idx" UNIQUE="false"/>
+        <INDEX COMMENT="Index on the submission marked field" FIELDS="timemarked" NAME="kal_marked_idx" UNIQUE="false"/>
+        <INDEX COMMENT="Index on the mailed field" FIELDS="mailed" NAME="kal_mailed_idx" UNIQUE="false"/>
       </INDEXES>
     </TABLE>
   </TABLES>

/home/runner/work/moodle/moodle/lib/tests/db/plugin_checks_test.php:55
/home/runner/work/moodle/moodle/lib/phpunit/classes/basic_testcase.php:64
core\db\plugin_checks_test::test_db_install_file with data set "mod_kalvidres" ('mod_kalvidres', 'mod', 'kalvidres', '/home/runner/work/moodle/mood...vidres')
XMLDB structure does not match the install.xml file in /home/runner/work/moodle/moodle/mod/kalvidres/db/install.xml
Failed asserting that two DOM documents are equal.
--- Expected
+++ Actual
@@ @@
   <TABLES>
     <TABLE COMMENT="Kaltura video resource module instances are stored here" NAME="kalvidres">
       <FIELDS>
-        <FIELD LENGTH="10" NAME="id" NEXT="course" NOTNULL="true" SEQUENCE="true" TYPE="int" UNSIGNED="true"/>
-        <FIELD DEFAULT="0" LENGTH="10" NAME="course" NEXT="name" NOTNULL="true" PREVIOUS="id" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
-        <FIELD LENGTH="255" NAME="name" NEXT="intro" NOTNULL="true" PREVIOUS="course" SEQUENCE="false" TYPE="char"/>
-        <FIELD LENGTH="small" NAME="intro" NEXT="introformat" NOTNULL="false" PREVIOUS="name" SEQUENCE="false" TYPE="text"/>
-        <FIELD DEFAULT="0" LENGTH="4" NAME="introformat" NEXT="entry_id" NOTNULL="true" PREVIOUS="intro" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
-        <FIELD COMMENT="Kaltura video entry ids" LENGTH="50" NAME="entry_id" NEXT="video_title" NOTNULL="true" PREVIOUS="introformat" SEQUENCE="false" TYPE="char"/>
-        <FIELD COMMENT="Video title" LENGTH="256" NAME="video_title" NEXT="uiconf_id" NOTNULL="true" PREVIOUS="entry_id" SEQUENCE="false" TYPE="char"/>
-        <FIELD COMMENT="The player to be used for playback" DEFAULT="0" LENGTH="10" NAME="uiconf_id" NEXT="widescreen" NOTNULL="true" PREVIOUS="video_title" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
-        <FIELD COMMENT="Video playback dimensions widescreen or normal" DEFAULT="0" LENGTH="1" NAME="widescreen" NEXT="height" NOTNULL="true" PREVIOUS="uiconf_id" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
-        <FIELD COMMENT="Video height" DEFAULT="0" LENGTH="10" NAME="height" NEXT="width" NOTNULL="true" PREVIOUS="widescreen" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
-        <FIELD COMMENT="Video playback width" DEFAULT="0" LENGTH="10" NAME="width" NEXT="source" NOTNULL="true" PREVIOUS="height" SEQUENCE="false" TYPE="int"/>
-        <FIELD COMMENT="The URL to retrieve the rendered video and metadata." NAME="source" NEXT="metadata" NOTNULL="false" PREVIOUS="width" SEQUENCE="false" TYPE="text"/>
-        <FIELD COMMENT="Stores a base 64 encoded serialized metadata object." NAME="metadata" NEXT="timemodified" NOTNULL="false" PREVIOUS="source" SEQUENCE="false" TYPE="text"/>
-        <FIELD COMMENT="Time modified" DEFAULT="0" LENGTH="10" NAME="timemodified" NEXT="timecreated" NOTNULL="true" PREVIOUS="metadata" SEQUENCE="false" TYPE="int"/>
-        <FIELD COMMENT="Time created" DEFAULT="0" LENGTH="10" NAME="timecreated" NOTNULL="true" PREVIOUS="timemodified" SEQUENCE="false" TYPE="int" UNSIGNED="true"/>
+        <FIELD LENGTH="10" NAME="id" NOTNULL="true" SEQUENCE="true" TYPE="int"/>
+        <FIELD DEFAULT="0" LENGTH="10" NAME="course" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD LENGTH="255" NAME="name" NOTNULL="true" SEQUENCE="false" TYPE="char"/>
+        <FIELD NAME="intro" NOTNULL="false" SEQUENCE="false" TYPE="text"/>
+        <FIELD DEFAULT="0" LENGTH="4" NAME="introformat" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Kaltura video entry ids" LENGTH="50" NAME="entry_id" NOTNULL="true" SEQUENCE="false" TYPE="char"/>
+        <FIELD COMMENT="Video title" LENGTH="256" NAME="video_title" NOTNULL="true" SEQUENCE="false" TYPE="char"/>
+        <FIELD COMMENT="The player to be used for playback" DEFAULT="0" LENGTH="10" NAME="uiconf_id" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Video playback dimensions widescreen or normal" DEFAULT="0" LENGTH="1" NAME="widescreen" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Video height" DEFAULT="0" LENGTH="10" NAME="height" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Video playback width" DEFAULT="0" LENGTH="10" NAME="width" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="The URL to retrieve the rendered video and metadata." NAME="source" NOTNULL="false" SEQUENCE="false" TYPE="text"/>
+        <FIELD COMMENT="Stores a base 64 encoded serialized metadata object." NAME="metadata" NOTNULL="false" SEQUENCE="false" TYPE="text"/>
+        <FIELD COMMENT="Time modified" DEFAULT="0" LENGTH="10" NAME="timemodified" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
+        <FIELD COMMENT="Time created" DEFAULT="0" LENGTH="10" NAME="timecreated" NOTNULL="true" SEQUENCE="false" TYPE="int"/>
       </FIELDS>
       <KEYS>
         <KEY FIELDS="id" NAME="primary" TYPE="primary"/>

/home/runner/work/moodle/moodle/lib/tests/db/plugin_checks_test.php:55
/home/runner/work/moodle/moodle/lib/phpunit/classes/basic_testcase.php:64

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions