Skip to content

Commit 5a5dcbd

Browse files
Pass -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to CMake
Googletest is broken across the Ubuntu images provided by GitHub, and it complains about incompatibility with CMake versions < 3.5. Since we use googletest as a third-party submodule, which we do not have control over, lets pass -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to keep CMake compatible as a workaround. Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
1 parent 4ce8819 commit 5a5dcbd

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/continuous-integration.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ jobs:
217217
git submodule update --init --recursive
218218
pushd googletest/googletest
219219
git checkout release-1.8.0
220-
cmake -DBUILD_SHARED_LIBS=ON .
220+
cmake -DBUILD_SHARED_LIBS=ON -DCMAKE_POLICY_VERSION_MINIMUM=3.5 .
221221
make
222222
popd
223223
- name: Automake

bootstrap.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ git submodule update --init --recursive
1515
# configure googletest
1616
pushd googletest/googletest
1717
git checkout release-1.8.0
18-
cmake -DBUILD_SHARED_LIBS=ON .
18+
cmake -DBUILD_SHARED_LIBS=ON -DCMAKE_POLICY_VERSION_MINIMUM=3.5 .
1919
make
2020
popd
2121

0 commit comments

Comments
 (0)