Skip to content

Commit 36e29ab

Browse files
authored
fix XdsTestServer/TestServiceServer listenAddresses conflict (grpc#11612)
1 parent ca43d78 commit 36e29ab

File tree

2 files changed

+16
-9
lines changed

2 files changed

+16
-9
lines changed

interop-testing/src/main/java/io/grpc/testing/integration/TestServiceServer.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -180,18 +180,22 @@ void start() throws Exception {
180180
break;
181181
case IPV4:
182182
SocketAddress v4Address = Util.getV4Address(port);
183+
InetSocketAddress localV4Address = new InetSocketAddress("127.0.0.1", port);
183184
serverBuilder =
184-
NettyServerBuilder.forAddress(new InetSocketAddress("127.0.0.1", port), serverCreds);
185-
if (v4Address == null) {
185+
NettyServerBuilder.forAddress(localV4Address, serverCreds);
186+
if (v4Address != null && !v4Address.equals(localV4Address)) {
186187
((NettyServerBuilder) serverBuilder).addListenAddress(v4Address);
187188
}
188189
break;
189190
case IPV6:
190191
List<SocketAddress> v6Addresses = Util.getV6Addresses(port);
192+
InetSocketAddress localV6Address = new InetSocketAddress("::1", port);
191193
serverBuilder =
192-
NettyServerBuilder.forAddress(new InetSocketAddress("::1", port), serverCreds);
194+
NettyServerBuilder.forAddress(localV6Address, serverCreds);
193195
for (SocketAddress address : v6Addresses) {
194-
((NettyServerBuilder)serverBuilder).addListenAddress(address);
196+
if (!address.equals(localV6Address)) {
197+
((NettyServerBuilder) serverBuilder).addListenAddress(address);
198+
}
195199
}
196200
break;
197201
default:

interop-testing/src/main/java/io/grpc/testing/integration/XdsTestServer.java

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -242,18 +242,21 @@ void start() throws Exception {
242242
break;
243243
case IPV4:
244244
SocketAddress v4Address = Util.getV4Address(port);
245+
InetSocketAddress localV4Address = new InetSocketAddress("127.0.0.1", port);
245246
serverBuilder = NettyServerBuilder.forAddress(
246-
new InetSocketAddress("127.0.0.1", port), insecureServerCreds);
247-
if (v4Address != null) {
247+
localV4Address, insecureServerCreds);
248+
if (v4Address != null && !v4Address.equals(localV4Address) ) {
248249
((NettyServerBuilder) serverBuilder).addListenAddress(v4Address);
249250
}
250251
break;
251252
case IPV6:
252253
List<SocketAddress> v6Addresses = Util.getV6Addresses(port);
253-
serverBuilder = NettyServerBuilder.forAddress(
254-
new InetSocketAddress("::1", port), insecureServerCreds);
254+
InetSocketAddress localV6Address = new InetSocketAddress("::1", port);
255+
serverBuilder = NettyServerBuilder.forAddress(localV6Address, insecureServerCreds);
255256
for (SocketAddress address : v6Addresses) {
256-
((NettyServerBuilder)serverBuilder).addListenAddress(address);
257+
if (!address.equals(localV6Address)) {
258+
((NettyServerBuilder) serverBuilder).addListenAddress(address);
259+
}
257260
}
258261
break;
259262
default:

0 commit comments

Comments
 (0)