Skip to content

Commit 54c962a

Browse files
committed
Fix missing software deps
1 parent a5ec1ae commit 54c962a

File tree

4 files changed

+26
-13
lines changed

4 files changed

+26
-13
lines changed

buildscripts/grpc-java-artifacts/Dockerfile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,10 @@ RUN mkdir -p "$ANDROID_HOME/cmdline-tools" && \
2727
mv "$ANDROID_HOME/cmdline-tools/cmdline-tools" "$ANDROID_HOME/cmdline-tools/latest" && \
2828
yes | "$ANDROID_HOME/cmdline-tools/latest/bin/sdkmanager" --licenses
2929

30+
RUN curl -Ls https://github.com/Kitware/CMake/releases/download/v3.26.3/cmake-3.26.3-linux-x86_64.tar.gz | \
31+
tar xz -C /var/local
32+
3033
# Install Maven
3134
RUN curl -Ls https://dlcdn.apache.org/maven/maven-3/3.8.8/binaries/apache-maven-3.8.8-bin.tar.gz | \
3235
tar xz -C /var/local
33-
ENV PATH /var/local/apache-maven-3.8.8/bin:$PATH
36+
ENV PATH /var/local/cmake-3.26.3-linux-x86_64/bin:/var/local/apache-maven-3.8.8/bin:$PATH

buildscripts/grpc-java-artifacts/Dockerfile.multiarch.base

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,15 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
1010
g++-aarch64-linux-gnu \
1111
g++-powerpc64le-linux-gnu \
1212
openjdk-8-jdk \
13+
pkg-config \
1314
&& \
1415
rm -rf /var/lib/apt/lists/*
16+
17+
RUN curl -Ls https://github.com/Kitware/CMake/releases/download/v3.26.3/cmake-3.26.3-linux-x86_64.tar.gz | \
18+
tar xz -C /var/local
19+
20+
# Install Maven
21+
RUN curl -Ls https://dlcdn.apache.org/maven/maven-3/3.8.8/binaries/apache-maven-3.8.8-bin.tar.gz | \
22+
tar xz -C /var/local
23+
ENV PATH /var/local/cmake-3.26.3-linux-x86_64/bin:/var/local/apache-maven-3.8.8/bin:$PATH
24+

buildscripts/grpc-java-artifacts/Dockerfile.ubuntu2004.base

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,14 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
99
curl \
1010
g++-s390x-linux-gnu \
1111
openjdk-8-jdk \
12+
pkg-config \
1213
&& \
1314
rm -rf /var/lib/apt/lists/*
15+
16+
RUN curl -Ls https://github.com/Kitware/CMake/releases/download/v3.26.3/cmake-3.26.3-linux-x86_64.tar.gz | \
17+
tar xz -C /var/local
18+
19+
# Install Maven
20+
RUN curl -Ls https://dlcdn.apache.org/maven/maven-3/3.8.8/binaries/apache-maven-3.8.8-bin.tar.gz | \
21+
tar xz -C /var/local
22+
ENV PATH /var/local/cmake-3.26.3-linux-x86_64/bin:/var/local/apache-maven-3.8.8/bin:$PATH

buildscripts/make_dependencies.sh

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ set -evux -o pipefail
55

66
PROTOBUF_VERSION=22.5
77
ABSL_VERSION=20230125.4
8-
CMAKE_VERSION=3.13.4
8+
CMAKE_VERSION=3.26.3
99

1010
# ARCH is x86_64 bit unless otherwise specified.
1111
ARCH="${ARCH:-x86_64}"
@@ -30,16 +30,6 @@ if [ -f ${INSTALL_DIR}/bin/protoc ]; then
3030
echo "Not building protobuf. Already built"
3131
# TODO(ejona): swap to `brew install --devel protobuf` once it is up-to-date
3232
else
33-
if [[ ! -d "cmake-${CMAKE_VERSION}" ]]; then
34-
curl -Ls "https://github.com/Kitware/CMake/releases/download/v${CMAKE_VERSION}/cmake-${CMAKE_VERSION}.tar.gz" | tar xz
35-
fi
36-
# the same source dir is used for 32 and 64 bit builds, so we need to clean stale data first
37-
rm -rf "$DOWNLOAD_DIR/cmake-${CMAKE_VERSION}/bin"
38-
cd "$DOWNLOAD_DIR/cmake-${CMAKE_VERSION}"
39-
./bootstrap
40-
make
41-
make install
42-
ln -s /usr/local/bin/cmake /usr/bin/cmake
4333
cd "$DOWNLOAD_DIR"
4434
if [[ ! -d "protobuf-${PROTOBUF_VERSION}" ]]; then
4535
curl -Ls "https://github.com/google/protobuf/releases/download/v${PROTOBUF_VERSION}/protobuf-${PROTOBUF_VERSION}.tar.gz" | tar xz
@@ -55,7 +45,8 @@ else
5545
if [[ "$ARCH" == x86* ]]; then
5646
CFLAGS=-m${ARCH#*_} CXXFLAGS=-m${ARCH#*_} cmake .. \
5747
-DCMAKE_CXX_STANDARD=14 -Dprotobuf_BUILD_TESTS=OFF -DBUILD_SHARED_LIBS=OFF \
58-
-DCMAKE_INSTALL_PREFIX="$INSTALL_DIR" -DABSL_INTERNAL_AT_LEAST_CXX17=0
48+
-DCMAKE_INSTALL_PREFIX="$INSTALL_DIR" -DABSL_INTERNAL_AT_LEAST_CXX17=0 \
49+
-B.
5950
else
6051
if [[ "$ARCH" == aarch_64 ]]; then
6152
GCC_ARCH=aarch64-linux-gnu

0 commit comments

Comments
 (0)