Skip to content

Commit 7abbc4a

Browse files
committed
Review comments.
1 parent f2bfa63 commit 7abbc4a

File tree

2 files changed

+11
-13
lines changed

2 files changed

+11
-13
lines changed

xds/src/main/java/io/grpc/xds/CdsLoadBalancer2.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ final class CdsLoadBalancer2 extends LoadBalancer {
5757
private final XdsLogger logger;
5858
private final Helper helper;
5959
private final LoadBalancerRegistry lbRegistry;
60-
private final GracefulSwitchLoadBalancer delegate;
60+
private GracefulSwitchLoadBalancer delegate;
6161
// Following fields are effectively final.
6262
private String clusterName;
6363
private Subscription clusterSubscription;
@@ -182,6 +182,7 @@ public void shutdown() {
182182
clusterSubscription.close();
183183
clusterSubscription = null;
184184
}
185+
delegate = new GracefulSwitchLoadBalancer(helper);
185186
}
186187

187188
@CheckReturnValue // don't forget to return up the stack after the fail call

xds/src/test/java/io/grpc/xds/CdsLoadBalancer2Test.java

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -474,22 +474,19 @@ public void discoverAggregateCluster_createsPriorityLbPolicy() {
474474
assertThat(childLbConfig.childConfigs).hasSize(3);
475475
PriorityLoadBalancerProvider.PriorityLbConfig.PriorityChildConfig childConfig3 =
476476
childLbConfig.childConfigs.get(cluster3);
477-
assertThat(childConfig3.toString()).isEqualTo("PriorityChildConfig{childConfig="
478-
+ "GracefulSwitchLoadBalancer.Config{childFactory=CdsLoadBalancerProvider{"
479-
+ "policy=cds_experimental, priority=5, available=true}, childConfig=CdsConfig{"
480-
+ "name=cluster-03.googleapis.com, isDynamic=false}}, ignoreReresolution=false}");
477+
assertThat(
478+
GracefulSwitchLoadBalancerAccessor.getChildProvider(childConfig3.childConfig).getPolicyName())
479+
.isEqualTo("cds_experimental");
481480
PriorityLoadBalancerProvider.PriorityLbConfig.PriorityChildConfig childConfig4 =
482481
childLbConfig.childConfigs.get(cluster4);
483-
assertThat(childConfig4.toString()).isEqualTo("PriorityChildConfig{childConfig="
484-
+ "GracefulSwitchLoadBalancer.Config{childFactory=CdsLoadBalancerProvider{"
485-
+ "policy=cds_experimental, priority=5, available=true}, childConfig=CdsConfig{"
486-
+ "name=cluster-04.googleapis.com, isDynamic=false}}, ignoreReresolution=false}");
482+
assertThat(
483+
GracefulSwitchLoadBalancerAccessor.getChildProvider(childConfig4.childConfig).getPolicyName())
484+
.isEqualTo("cds_experimental");
487485
PriorityLoadBalancerProvider.PriorityLbConfig.PriorityChildConfig childConfig2 =
488486
childLbConfig.childConfigs.get(cluster2);
489-
assertThat(childConfig2.toString()).isEqualTo("PriorityChildConfig{childConfig="
490-
+ "GracefulSwitchLoadBalancer.Config{childFactory=CdsLoadBalancerProvider{"
491-
+ "policy=cds_experimental, priority=5, available=true}, childConfig=CdsConfig{"
492-
+ "name=cluster-02.googleapis.com, isDynamic=false}}, ignoreReresolution=false}");
487+
assertThat(
488+
GracefulSwitchLoadBalancerAccessor.getChildProvider(childConfig2.childConfig).getPolicyName())
489+
.isEqualTo("cds_experimental");
493490
}
494491

495492
@Test

0 commit comments

Comments
 (0)