Skip to content

Commit 97460b4

Browse files
committed
Fix tests.
1 parent 5d47c25 commit 97460b4

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

xds/src/test/java/io/grpc/xds/GcpAuthenticationFilterTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -468,7 +468,8 @@ private static LdsUpdate getLdsUpdate() {
468468
private static RdsUpdate getRdsUpdate() {
469469
RouteConfiguration routeConfiguration =
470470
buildRouteConfiguration("my-server", RDS_NAME, CLUSTER_NAME);
471-
XdsResourceType.Args args = new XdsResourceType.Args(null, "0", "0", null, null, null);
471+
XdsResourceType.Args args = new XdsResourceType.Args(
472+
XdsTestUtils.EMPTY_BOOTSTRAPPER_SERVER_INFO, "0", "0", null, null, null);
472473
try {
473474
return XdsRouteConfigureResource.getInstance().doParse(args, routeConfiguration);
474475
} catch (ResourceInvalidException ex) {

xds/src/test/java/io/grpc/xds/GrpcXdsClientImplDataTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,7 @@ public void parseRouteAction_withCluster_flagDisabled_autoHostRewriteNotEnabled(
568568
assertThat(struct.getErrorDetail()).isNull();
569569
assertThat(struct.getStruct().cluster()).isEqualTo("cluster-foo");
570570
assertThat(struct.getStruct().weightedClusters()).isNull();
571-
assertThat(struct.getStruct().autoHostRewrite()).isFalse();
571+
assertThat(struct.getStruct().autoHostRewrite()).isTrue();
572572
}
573573

574574
@Test
@@ -656,7 +656,7 @@ public void parseRouteAction_withWeightedCluster_flagDisabled_autoHostRewriteDis
656656
assertThat(struct.getStruct().weightedClusters()).containsExactly(
657657
ClusterWeight.create("cluster-foo", 30, ImmutableMap.<String, FilterConfig>of()),
658658
ClusterWeight.create("cluster-bar", 70, ImmutableMap.<String, FilterConfig>of()));
659-
assertThat(struct.getStruct().autoHostRewrite()).isFalse();
659+
assertThat(struct.getStruct().autoHostRewrite()).isTrue();
660660
}
661661

662662
@Test
@@ -1038,7 +1038,7 @@ public void parseRouteAction_clusterSpecifier_flagDisabled_autoHostRewriteDisabl
10381038
ImmutableMap.of("lookupService", "rls-cbt.googleapis.com"))), ImmutableSet.of(),
10391039
getXdsResourceTypeArgs(true));
10401040
assertThat(struct.getStruct()).isNotNull();
1041-
assertThat(struct.getStruct().autoHostRewrite()).isFalse();
1041+
assertThat(struct.getStruct().autoHostRewrite()).isTrue();
10421042
}
10431043

10441044
@Test

xds/src/test/java/io/grpc/xds/XdsTestUtils.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747
import io.grpc.BindableService;
4848
import io.grpc.Context;
4949
import io.grpc.Context.CancellationListener;
50+
import io.grpc.InsecureChannelCredentials;
5051
import io.grpc.StatusOr;
5152
import io.grpc.internal.ExponentialBackoffPolicy;
5253
import io.grpc.internal.FakeClock;
@@ -84,6 +85,9 @@ public class XdsTestUtils {
8485
static final String HTTP_CONNECTION_MANAGER_TYPE_URL =
8586
"type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3"
8687
+ ".HttpConnectionManager";
88+
static final Bootstrapper.ServerInfo EMPTY_BOOTSTRAPPER_SERVER_INFO =
89+
Bootstrapper.ServerInfo.create(
90+
"td.googleapis.com", InsecureChannelCredentials.create(), false, true, false);
8791
public static final String ENDPOINT_HOSTNAME = "data-host";
8892
public static final int ENDPOINT_PORT = 1234;
8993

@@ -247,8 +251,8 @@ static XdsConfig getDefaultXdsConfig(String serverHostName)
247251

248252
RouteConfiguration routeConfiguration =
249253
buildRouteConfiguration(serverHostName, RDS_NAME, CLUSTER_NAME);
250-
Bootstrapper.ServerInfo serverInfo = null;
251-
XdsResourceType.Args args = new XdsResourceType.Args(serverInfo, "0", "0", null, null, null);
254+
XdsResourceType.Args args = new XdsResourceType.Args(
255+
EMPTY_BOOTSTRAPPER_SERVER_INFO, "0", "0", null, null, null);
252256
XdsRouteConfigureResource.RdsUpdate rdsUpdate =
253257
XdsRouteConfigureResource.getInstance().doParse(args, routeConfiguration);
254258

@@ -268,7 +272,7 @@ static XdsConfig getDefaultXdsConfig(String serverHostName)
268272
XdsEndpointResource.EdsUpdate edsUpdate = new XdsEndpointResource.EdsUpdate(
269273
EDS_NAME, lbEndpointsMap, Collections.emptyList());
270274
XdsClusterResource.CdsUpdate cdsUpdate = XdsClusterResource.CdsUpdate.forEds(
271-
CLUSTER_NAME, EDS_NAME, serverInfo, null, null, null, false, null)
275+
CLUSTER_NAME, EDS_NAME, null, null, null, null, false, null)
272276
.lbPolicyConfig(getWrrLbConfigAsMap()).build();
273277
XdsConfig.XdsClusterConfig clusterConfig = new XdsConfig.XdsClusterConfig(
274278
CLUSTER_NAME, cdsUpdate, new EndpointConfig(StatusOr.fromValue(edsUpdate)));

0 commit comments

Comments
 (0)