Skip to content

Commit e2b4704

Browse files
committed
Remove child Lb policy listener used only in test now after the backoff timer changes.
Fix failing tests.
1 parent 6be4b7c commit e2b4704

File tree

3 files changed

+1
-12
lines changed

3 files changed

+1
-12
lines changed

rls/src/main/java/io/grpc/rls/LbPolicyConfiguration.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -401,13 +401,6 @@ public void updateBalancingState(ConnectivityState newState, SubchannelPicker ne
401401
}
402402
}
403403

404-
/** Listener for child lb status change events. */
405-
interface ChildLbStatusListener {
406-
407-
/** Notifies when child lb status changes. */
408-
void onStatusChanged(ConnectivityState newState);
409-
}
410-
411404
private static final class RefCountedChildPolicyWrapper
412405
implements ObjectPool<ChildPolicyWrapper> {
413406

rls/src/test/java/io/grpc/rls/LbPolicyConfigurationTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
import io.grpc.Status;
4040
import io.grpc.SynchronizationContext;
4141
import io.grpc.rls.ChildLoadBalancerHelper.ChildLoadBalancerHelperProvider;
42-
import io.grpc.rls.LbPolicyConfiguration.ChildLbStatusListener;
4342
import io.grpc.rls.LbPolicyConfiguration.ChildLoadBalancingPolicy;
4443
import io.grpc.rls.LbPolicyConfiguration.ChildPolicyWrapper;
4544
import io.grpc.rls.LbPolicyConfiguration.ChildPolicyWrapper.ChildPolicyReportingHelper;
@@ -61,7 +60,6 @@ public class LbPolicyConfigurationTest {
6160
private final LoadBalancer lb = mock(LoadBalancer.class);
6261
private final SubchannelStateManager subchannelStateManager = new SubchannelStateManagerImpl();
6362
private final SubchannelPicker picker = mock(SubchannelPicker.class);
64-
private final ChildLbStatusListener childLbStatusListener = mock(ChildLbStatusListener.class);
6563
private final ResolvedAddressFactory resolvedAddressFactory =
6664
new ResolvedAddressFactory() {
6765
@Override
@@ -184,7 +182,6 @@ public void updateBalancingState_triggersListener() {
184182

185183
childPolicyReportingHelper.updateBalancingState(ConnectivityState.READY, childPicker);
186184

187-
verify(childLbStatusListener).onStatusChanged(ConnectivityState.READY);
188185
assertThat(childPolicyWrapper.getPicker()).isEqualTo(childPicker);
189186
// picker governs childPickers will be reported to parent LB
190187
verify(helper).updateBalancingState(ConnectivityState.READY, picker);

rls/src/test/java/io/grpc/rls/RlsLoadBalancerTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -456,8 +456,7 @@ public void lb_working_withDefaultTarget_noRlsResponse() throws Exception {
456456
(FakeSubchannel) markReadyAndGetPickResult(inOrder, searchSubchannelArgs).getSubchannel();
457457
assertThat(searchSubchannel).isNotNull();
458458
assertThat(searchSubchannel).isNotSameInstanceAs(fallbackSubchannel);
459-
times = PickFirstLoadBalancerProvider.isEnabledNewPickFirst() ? 1 : 2;
460-
verifyLongCounterAdd("grpc.lb.rls.target_picks", times, 1, "wilderness", "complete");
459+
verifyLongCounterAdd("grpc.lb.rls.target_picks", 1, 1, "wilderness", "complete");
461460

462461
// create rescue subchannel
463462
picker.pickSubchannel(rescueSubchannelArgs);

0 commit comments

Comments
 (0)