fix(dbinstance): correct return values

Charel Baum · Charel Baum · commit 9fc98b3300f5 · 2022-12-20T10:30:11.000+01:00
Signed-off-by: Charel Baum &lt;charel.baum@accenture.com&gt;
diff --git a/pkg/controller/rds/dbinstance/setup.go b/pkg/controller/rds/dbinstance/setup.go
@@ -484,13 +484,13 @@ func areVPCSecurityGroupIDsUpToDate(cr *svcapitypes.DBInstance, out *svcsdk.DBIn
 	// if user is fine with default SG or lets DBCluster manage it
 	// (removing all SGs is not possible, AWS will keep last set SGs)
 	if len(desiredIDs) == 0 {
-		return false
+		return true
 	}
 
 	actualGroups := out.VpcSecurityGroups
 
 	if len(desiredIDs) != len(actualGroups) {
-		return true
+		return false
 	}
 
 	actualIDs := make([]string, 0, len(actualGroups))

Original file line number	Diff line number	Diff line change
`@@ -484,13 +484,13 @@ func areVPCSecurityGroupIDsUpToDate(cr svcapitypes.DBInstance, out svcsdk.DBIn`
`484`	`484`	`// if user is fine with default SG or lets DBCluster manage it`
`485`	`485`	`// (removing all SGs is not possible, AWS will keep last set SGs)`
`486`	`486`	`if len(desiredIDs) == 0 {`
`487`		`- return false`
	`487`	`+ return true`
`488`	`488`	`}`
`489`	`489`
`490`	`490`	`actualGroups := out.VpcSecurityGroups`
`491`	`491`
`492`	`492`	`if len(desiredIDs) != len(actualGroups) {`
`493`		`- return true`
	`493`	`+ return false`
`494`	`494`	`}`
`495`	`495`
`496`	`496`	`actualIDs := make([]string, 0, len(actualGroups))`