Fix ignores malformed testcase (elastic#125337)

Fix and unmute testSynthesizeArrayRandomIgnoresMalformed

Author: jordan-powers

muted-tests.yml

@@ -393,9 +393,6 @@ tests:
 - class: org.elasticsearch.reservedstate.service.ReservedClusterStateServiceTests
   method: testProcessMultipleChunks
   issue: https://github.com/elastic/elasticsearch/issues/125305
-- class: org.elasticsearch.index.mapper.NativeArrayIntegrationTestCase
-  method: testSynthesizeArrayRandomIgnoresMalformed
-  issue: https://github.com/elastic/elasticsearch/issues/125319
 
 # Examples:
 #

server/src/test/java/org/elasticsearch/index/mapper/NativeArrayIntegrationTestCase.java

@@ -83,10 +83,10 @@ public void testSynthesizeArrayRandomIgnoresMalformed() throws Exception {
             var expectedDocument = jsonBuilder().startObject();
             var inputDocument = jsonBuilder().startObject();
 
-            boolean expectedContainsArray = values.length > 0 || malformed.length > 1;
-            if (expectedContainsArray) {
+            boolean expectedIsArray = values.length != 0 || malformed.length != 1;
+            if (expectedIsArray) {
                 expectedDocument.startArray("field");
-            } else if (malformed.length > 0) {
+            } else {
                 expectedDocument.field("field");
             }
             inputDocument.startArray("field");
@@ -113,7 +113,7 @@ public void testSynthesizeArrayRandomIgnoresMalformed() throws Exception {
                 }
             }
 
-            if (expectedContainsArray) {
+            if (expectedIsArray) {
                 expectedDocument.endArray();
             }
             expectedDocument.endObject();