precommit

Author: kanoshiou

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/optimizer/rules/logical/ReplaceAggregateNestedExpressionWithEval.java

@@ -34,6 +34,7 @@
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 
 /**
@@ -277,7 +278,7 @@ private static String syntheticName(Expression expression, Expression func, int
 
     private static Literal formatToMinimalInterval(String format, Source source) {
         try {
-            DateTimeFormatter formatter = DateTimeFormatter.ofPattern(format);
+            DateTimeFormatter formatter = DateTimeFormatter.ofPattern(format, Locale.ROOT);
             String formatterAsString = formatter.toString();
             if (formatterAsString.contains(ChronoField.NANO_OF_SECOND.toString())
                 || formatterAsString.contains(ChronoField.NANO_OF_DAY.toString())) {

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/LogicalPlanOptimizerTests.java

@@ -7873,22 +7873,14 @@ public void testSampleNoPushDownChangePoint() {
      */
     public void testReplaceGroupingByDateFormatWithDateTrunc() {
 
-        List<String> formats = List.of(
-            "yyyy",
-            "YYYY",
-            "MM/yyyy",
-            "yy-mm",
-            "yyyy-dd-MM",
-            "DD",
-            "yyyy-MM-dd HH:mm:ss"
-        );
+        List<String> formats = List.of("yyyy", "YYYY", "MM/yyyy", "yy-mm", "yyyy-dd-MM", "DD", "yyyy-MM-dd HH:mm:ss");
 
         for (var format : formats) {
             var query = """
                 FROM test
                 | STATS avg = AVG(salary) BY date = DATE_FORMAT("%s", hire_date)
                 """;
-            String format1 = String.format(query, format);
+            String format1 = String.format(Locale.ROOT, query, format);
             var optimized = optimizedPlan(format1);
 
             var project = as(optimized, Project.class);