Skip to content

Commit d7276cd

Browse files
committed
feat: Display whether an error happened during render or init
1 parent 1eb4edf commit d7276cd

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/components/base/base_component.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -767,7 +767,7 @@ describe('Component', function() {
767767
'render_func': my_render
768768
})
769769
my_render.should.be.called()
770-
assert.equal(d3.select('p.error').text(), message)
770+
assert.equal(d3.select('p.error').text(), message + ' [render]')
771771
})
772772

773773
it(`error message when error happens during init() (${message})`, () => {
@@ -777,7 +777,7 @@ describe('Component', function() {
777777
'has_init': true
778778
})
779779
my_init.should.be.called()
780-
assert.equal(d3.select('p.error').text(), message)
780+
assert.equal(d3.select('p.error').text(), message + ' [bind]')
781781
})
782782
})
783783
})

src/components/base/bind.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const create_element = (init_func, instance_args, selection) => {
1414
return (typeof init_func === 'function')
1515
? init_func(instance_args, selection) : selection.append('span')
1616
} catch(error) {
17-
selection.call(show_error_message(error))
17+
selection.call(show_error_message(`${error} [bind]`))
1818
}
1919
}
2020

src/components/base/render.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const call_render_function = (args, instance_args, selection, element) =>
99
args.render(instance_args, selection, format_data(instance_args, data),
1010
element, data)
1111
} catch (error) {
12-
selection.call(show_error_message(error))
12+
selection.call(show_error_message(`${error} [render]`))
1313
}
1414
}
1515

@@ -23,7 +23,7 @@ const render_component_with_query = (args, instance_args, selection,
2323
element) => (data) =>
2424
with_spinner(selection)(
2525
execute_query(instance_args.query, data)(
26-
e => show_error_message(e)(selection)))(
26+
e => show_error_message(`${e} [render]`)(selection)))(
2727
call_render_function(args, instance_args, selection, element))
2828

2929
const has_query = (instance_args) =>

0 commit comments

Comments
 (0)