bump to 100% line coverage

Author: kanutocd

lib/twelvedata_ruby/response.rb

@@ -77,8 +77,6 @@ def extract_error_data(http_response)
             code: http_response.status
           }
         end
-      rescue StandardError
-        { message: "Unknown error", code: http_response.status }
       end
 
       def determine_error_class(status_code)

lib/twelvedata_ruby/utils.rb

@@ -25,10 +25,7 @@ def demodulize(obj)
       #   Utils.to_integer("123") #=> 123
       #   Utils.to_integer("abc", 0) #=> 0
       def to_integer(obj, default_value = nil)
-        return obj if obj.is_a?(Integer)
-        return default_value unless obj.to_s.match?(/^\d+$/)
-
-        Integer(obj.to_s)
+        obj.is_a?(Integer) ? obj : Integer(obj.to_s)
       rescue ArgumentError
         default_value
       end

spec/lib/twelvedata_ruby/response_spec.rb

@@ -592,5 +592,17 @@
         expect(result.status_code).to eq(500)
       end
     end
+
+    context "with unknown HTTP error status" do
+      before { stub_http_error(request, 999) }
+
+      it "creates ResponseError directly" do
+        http_response = TwelvedataRuby::Client.request(request)
+        result = described_class.resolve(http_response, request)
+
+        expect(result).to be_a(TwelvedataRuby::ResponseError)
+        expect(result.status_code).to eq(999)
+      end
+    end
   end
 end

spec/lib/twelvedata_ruby/utils_spec.rb

@@ -1,4 +1,4 @@
-# frozen_string_literal: true
+  # frozen_string_literal: true
 
 RSpec.describe TwelvedataRuby::Utils do
   describe ".demodulize" do

spec/support/http_stub_helpers.rb

@@ -61,15 +61,15 @@ def stub_http_error(request, status_code, **options)
   # @param request [TwelvedataRuby::Request] Request object to stub
   # @return [WebMock::RequestStub] WebMock stub
   def stub_timeout_error(request)
-    stub_connection_failure(request).to_timeout
+    stub_failure(request).to_timeout
   end
 
   # Stub a network connection error
   #
   # @param request [TwelvedataRuby::Request] Request object to stub
   # @return [WebMock::RequestStub] WebMock stub
   def stub_connection_error(request)
-    stub_connection_failure(request).to_raise(HTTPX::ConnectionError.new("Connection failed"))
+    stub_failure(request).to_raise(HTTPX::ConnectionError.new("Connection failed"))
   end
 
   # Create a mock request object for testing
@@ -109,7 +109,7 @@ def stub_any_api_request(**options)
 
   private
 
-  def stub_connection_failure(request)
+  def stub_failure(request)
     stub_request(request.http_verb, request.full_url)
       .with(query: request.query_params, headers: { "User-Agent" => "httpx.rb/#{HTTPX::VERSION}", "Accept" => "*/*", "Accept-Encoding" => "gzip, deflate" })
   end