fix: removes cat_vars from tuner-results

and cleans learner_args by removing factors

Author: kapsner

.gitignore

@@ -53,3 +53,4 @@ inst/doc
 !vignettes/
 !vignettes/*.qmd
 revdep
+!.pre-commit-config.yaml

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: mlexperiments
 Title: Machine Learning Experiments
-Version: 0.0.8.9001
+Version: 0.0.8.9002
 Authors@R: 
     person("Lorenz A.", "Kapsner", , "[email protected]", role = c("cre", "aut", "cph"),
            comment = c(ORCID = "0000-0003-1866-860X"))
@@ -41,7 +41,7 @@ VignetteBuilder:
     quarto
 Config/testthat/edition: 3
 Config/testthat/parallel: false
-Date/Publication: 2025-10-16 08:00:41.425949 UTC
+Date/Publication: 2025-12-04 21:51:05.676424 UTC
 Encoding: UTF-8
 Roxygen: list(markdown = TRUE)
 SystemRequirements: Quarto command line tools

R/ml_helper_base.R

@@ -46,7 +46,11 @@
         X = names(params_not_optimized),
         FUN = function(x) {
           param <- params_not_optimized[[x]]
-          ifelse(is.factor(param), as.character(param), param)
+          if (isTRUE(is.factor(param))) {
+            return(as.character(param))
+          } else {
+            return(param)
+          }
         },
         simplify = FALSE,
         USE.NAMES = TRUE
@@ -68,7 +72,7 @@
       }
     }
   }
-
+  
   # append learner_args to params_not_optimized
   if (!is.null(self$learner_args)) {
     stopifnot(
@@ -95,6 +99,20 @@
       )) ==
         length(self$learner_args)
     )
+    
+    self$learner_args <- sapply(
+      X = names(self$learner_args),
+      FUN = function(x) {
+        param <- self$learner_args[[x]]
+        if (isTRUE(is.factor(param))) {
+          return(as.character(param))
+        } else {
+          return(param)
+        }
+      },
+      simplify = FALSE,
+      USE.NAMES = TRUE
+    )
 
     private$method_helper$execute_params$params_not_optimized <-
       kdry::list.append(

R/optimizer_helper_grid.R

@@ -66,6 +66,11 @@
         params$case_weights <- NULL
       }
 
+      # remove cat_vars from params, otherwise displaying is very strange
+      if ("cat_vars" %in% names(params)) {
+        params$cat_vars <- NULL
+      }
+
       ret <- data.table::as.data.table(
         c(
           list("setting_id" = setting_id),

data-raw/devstuffs.R

@@ -20,7 +20,7 @@ my_desc$set_authors(c(
 # Remove some author fields
 my_desc$del("Maintainer")
 # Set the version
-my_desc$set_version("0.0.8.9001")
+my_desc$set_version("0.0.8.9002")
 # The title of your package
 my_desc$set(Title = "Machine Learning Experiments")
 # The description of your package
@@ -156,6 +156,7 @@ usethis::use_build_ignore("README.qmd")
 usethis::use_build_ignore("docs")
 usethis::use_build_ignore("Meta")
 usethis::use_build_ignore("revdep")
+usethis::use_build_ignore(".pre-commit-config.yaml")
 
 usethis::use_git_ignore("!NEWS.md")
 usethis::use_git_ignore("!README.md")