fix bug in update script: if a task was deleted it was saved shortly after, throwing an exception

Author: corentinbettiol

README.md

@@ -9,6 +9,7 @@ the bugboard updates and sort [bugherd](https://www.bugherd.com/)'s tasks and co
 You will need `python` 3 & `django`.
 
 Some sensitive data are read using `os.environ('KEY')`, you will need to `export` them in order to successfully launch the bugboard:
+ * `BUGHERD_API` : The access key used to get content from bugherd.com/api_v2/
  * `SECRET_KEY` : The django secret key.
  * `DB_USER` : PSQL username.
  * `DB_PASS` : PSQL password.

bugboard/management/commands/updatebbdb.py

@@ -3,12 +3,12 @@
 import pytz
 import requests
 import datetime
-from django.core.management.base import BaseCommand
 from bugboard.models import Tag
 from bugboard.models import Task
 from bugboard.models import Member
 from bugboard.models import Project
 from bugboard.models import Comment
+from django.core.management.base import BaseCommand
 
 
 class Command(BaseCommand):
@@ -223,10 +223,6 @@ def update_task_details(self, id_project, t):
                 task.status = t.get('status', task.status)
                 task.admin_link = t.get('admin_link', task.admin_link)
 
-            # if updated task is closed, then delete it
-            if task.status == 'closed':
-                task.delete()
-
         # or create it if it doesn't exist
         except Task.DoesNotExist:
             task = Task(
@@ -250,7 +246,14 @@ def update_task_details(self, id_project, t):
             )
             self.task_tag_list.append([t['id'], t['tag_names']])
             self.task_assignee_list.append([t['id'], t['assignee_ids']])
-        task.save()
+
+        # if updated task is closed, then delete it
+        if task.status == 'closed':
+            task.delete()
+        else:
+            # else save it
+            task.save()
+
         self.display_new_action()
 
     def update_tags(self):