remove wait_timeout usage warning (#484)

* remove wait_timeout usage warning

* remove kern references

Author: mensfeld

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## 0.17.0 (Unreleased)
 - [Enhancement] Update `librdkafka` to `2.4.0`
 - [Feature] Add `#seek_by` to be able to seek for a message by topic, partition and offset (zinahia)
+- [Change] Remove old producer timeout API warnings.
 - [Fix] Switch to local release of librdkafka to mitigate its unavailability.
 
 ## 0.16.1 (2024-07-10)

lib/rdkafka/abstract_handle.rb

@@ -16,9 +16,6 @@ class AbstractHandle < FFI::Struct
     REGISTRY = {}
     # Default wait timeout is 31 years
     MAX_WAIT_TIMEOUT_FOREVER = 10_000_000_000
-    # Deprecation message for wait_timeout argument in wait method
-    WAIT_TIMEOUT_DEPRECATION_MESSAGE = "The 'wait_timeout' argument is deprecated and will be removed in future versions without replacement. " \
-      "We don't rely on it's value anymore. Please refactor your code to remove references to it."
 
     private_constant :MAX_WAIT_TIMEOUT_FOREVER
 
@@ -59,16 +56,13 @@ def pending?
     #
     # @param max_wait_timeout [Numeric, nil] Amount of time to wait before timing out.
     #   If this is nil we will wait forever
-    # @param wait_timeout [nil] deprecated
     # @param raise_response_error [Boolean] should we raise error when waiting finishes
     #
     # @return [Object] Operation-specific result
     #
     # @raise [RdkafkaError] When the operation failed
     # @raise [WaitTimeoutError] When the timeout has been reached and the handle is still pending
-    def wait(max_wait_timeout: 60, wait_timeout: nil, raise_response_error: true)
-      Kernel.warn(WAIT_TIMEOUT_DEPRECATION_MESSAGE) unless wait_timeout.nil?
-
+    def wait(max_wait_timeout: 60, raise_response_error: true)
       timeout = max_wait_timeout ? monotonic_now + max_wait_timeout : MAX_WAIT_TIMEOUT_FOREVER
 
       @mutex.synchronize do

spec/rdkafka/abstract_handle_spec.rb

@@ -80,7 +80,6 @@ def create_result
       let(:pending_handle) { true }
 
       it "should wait until the timeout and then raise an error" do
-        expect(Kernel).not_to receive(:warn)
         expect {
           subject.wait(max_wait_timeout: 0.1)
         }.to raise_error Rdkafka::AbstractHandle::WaitTimeoutError, /test_operation/
@@ -90,22 +89,15 @@ def create_result
     context 'when pending_handle false' do
       let(:pending_handle) { false }
 
-      it 'should show a deprecation warning when wait_timeout is set' do
-        expect(Kernel).to receive(:warn).with(Rdkafka::AbstractHandle::WAIT_TIMEOUT_DEPRECATION_MESSAGE)
-        subject.wait(wait_timeout: 0.1)
-      end
-
       context "without error" do
         let(:result) { 1 }
 
         it "should return a result" do
-          expect(Kernel).not_to receive(:warn)
           wait_result = subject.wait
           expect(wait_result).to eq(result)
         end
 
         it "should wait without a timeout" do
-          expect(Kernel).not_to receive(:warn)
           wait_result = subject.wait(max_wait_timeout: nil)
           expect(wait_result).to eq(result)
         end
@@ -115,7 +107,6 @@ def create_result
         let(:response) { 20 }
 
         it "should raise an rdkafka error" do
-          expect(Kernel).not_to receive(:warn)
           expect {
             subject.wait
           }.to raise_error Rdkafka::RdkafkaError