Skip to content

Commit c818846

Browse files
authored
Revert "librdkafka v2.10.0 (#579)" (#584)
This reverts commit 3fd5b7d.
1 parent 8576ae4 commit c818846

File tree

10 files changed

+15
-13
lines changed

10 files changed

+15
-13
lines changed

CHANGELOG.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
11
# Rdkafka Changelog
22

3-
## 0.22.0 (Unreleased)
4-
- [Enhancement] Align default configuration with deprecation warnings of librdkafka `2.10.0`.
5-
- [Enhancement] Bump librdkafka to `2.10.0`.
3+
## 0.21.1 (Unreleased)
64
- [Enhancement] Support producing and consuming of headers with mulitple values (KIP-82).
75
- [Enhancement] Allow native Kafka customization poll time.
86
- [Enhancement] Roll out experimental jruby support.
9-
- [Enhancement] Add `logger` gem to dependencies since moved out of Ruby.
107

118
## 0.21.0 (2025-02-13)
129
- [Enhancement] Bump librdkafka to `2.8.0`

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,6 @@ bundle exec rake produce_messages
163163

164164
| rdkafka-ruby | librdkafka | patches |
165165
|-|-|-|
166-
| 0.22.0 (Unreleased) | 2.10.0 (2025-04-18) | yes |
167166
| 0.21.0 (2025-02-13) | 2.8.0 (2025-01-07) | yes |
168167
| 0.20.0 (2025-01-07) | 2.6.1 (2024-11-18) | yes |
169168
| 0.19.0 (2024-10-01) | 2.5.3 (2024-09-02) | yes |
Binary file not shown.

lib/rdkafka/config.rb

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,10 @@ def self.opaques
129129
end
130130

131131
# Default config that can be overwritten.
132-
DEFAULT_CONFIG = {}.freeze
132+
DEFAULT_CONFIG = {
133+
# Request api version so advanced features work
134+
:"api.version.request" => true
135+
}.freeze
133136

134137
# Required config that cannot be overwritten.
135138
REQUIRED_CONFIG = {

lib/rdkafka/version.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22

33
module Rdkafka
4-
VERSION = "0.22.0"
5-
LIBRDKAFKA_VERSION = "2.10.0"
6-
LIBRDKAFKA_SOURCE_SHA256 = "004b1cc2685d1d6d416b90b426a0a9d27327a214c6b807df6f9ea5887346ba3a"
4+
VERSION = "0.21.1"
5+
LIBRDKAFKA_VERSION = "2.8.0"
6+
LIBRDKAFKA_SOURCE_SHA256 = "5bd1c46f63265f31c6bfcedcde78703f77d28238eadf23821c2b43fc30be3e25"
77
end

rdkafka.gemspec

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ Gem::Specification.new do |gem|
2626
gem.add_dependency 'ffi', '~> 1.15'
2727
gem.add_dependency 'mini_portile2', '~> 2.6'
2828
gem.add_dependency 'rake', '> 12'
29-
gem.add_dependency 'logger', '>= 1.5'
3029

3130
gem.add_development_dependency 'pry'
3231
gem.add_development_dependency 'rspec', '~> 3.5'

spec/rdkafka/admin_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
describe '#describe_errors' do
3535
let(:errors) { admin.class.describe_errors }
3636

37-
it { expect(errors.size).to eq(172) }
37+
it { expect(errors.size).to eq(170) }
3838
it { expect(errors[-184]).to eq(code: -184, description: 'Local: Queue full', name: '_QUEUE_FULL') }
3939
it { expect(errors[21]).to eq(code: 21, description: 'Broker: Invalid required acks value', name: 'INVALID_REQUIRED_ACKS') }
4040
end

spec/rdkafka/config_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ def call(config, client_name); end
159159

160160
it "should use default configuration" do
161161
config = Rdkafka::Config.new
162-
expect(config[:"api.version.request"]).to eq nil
162+
expect(config[:"api.version.request"]).to eq true
163163
end
164164

165165
it "should create a consumer with valid config" do

spec/rdkafka/producer_spec.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,8 @@ def call(_, handle)
263263
expect(message.partition).to eq 1
264264
expect(message.payload).to eq "payload"
265265
expect(message.key).to eq "key"
266+
# Since api.version.request is on by default we will get
267+
# the message creation timestamp if it's not set.
266268
expect(message.timestamp).to be_within(10).of(Time.now)
267269
end
268270

spec/spec_helper.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,9 @@
1515

1616
def rdkafka_base_config
1717
{
18-
:"bootstrap.servers" => "localhost:9092"
18+
:"api.version.request" => false,
19+
:"broker.version.fallback" => "1.0",
20+
:"bootstrap.servers" => "localhost:9092",
1921
}
2022
end
2123

0 commit comments

Comments
 (0)