fix(amazonq): setMaven correctly aws#6384

## Problem
`setMaven` is being executed unnecessarily.

## Solution
Move the call to happen just before the local build starts.

Author: dhasani23

packages/core/src/amazonqGumby/chat/controller/controller.ts

@@ -53,11 +53,9 @@ import {
 import { CodeTransformTelemetryState } from '../../telemetry/codeTransformTelemetryState'
 import DependencyVersions from '../../models/dependencies'
 import { getStringHash } from '../../../shared/utilities/textUtilities'
-import { getVersionData } from '../../../codewhisperer/service/transformByQ/transformMavenHandler'
 import AdmZip from 'adm-zip'
 import { AuthError } from '../../../auth/sso/server'
 import {
-    setMaven,
     openBuildLogFile,
     parseBuildFile,
     validateSQLMetadataFile,
@@ -321,12 +319,6 @@ export class GumbyController {
                     telemetryJavaVersion = JDKToTelemetryValue(javaVersion) as CodeTransformJavaSourceVersionsAllowed
                 }
                 telemetry.record({ codeTransformLocalJavaVersion: telemetryJavaVersion })
-
-                await setMaven()
-                const versionInfo = await getVersionData()
-                const mavenVersionInfoMessage = `${versionInfo[0]} (${transformByQState.getMavenName()})`
-                telemetry.record({ buildSystemVersion: mavenVersionInfoMessage })
-
                 return validProjects
             })
             return validProjects

packages/core/src/codewhisperer/service/transformByQ/transformApiHandler.ts

@@ -448,6 +448,7 @@ export async function startJob(uploadId: string) {
                 target: { language: targetLanguageVersion }, // always JDK17
             },
         })
+        getLogger().info('CodeTransformation: called startJob API successfully')
         if (response.$response.requestId) {
             transformByQState.setJobFailureMetadata(` (request ID: ${response.$response.requestId})`)
         }
@@ -671,6 +672,7 @@ export async function pollTransformationJob(jobId: string, validStates: string[]
                 })
             }
             transformByQState.setPolledJobStatus(status)
+            getLogger().info(`CodeTransformation: polled job status = ${status}`)
 
             const errorMessage = response.transformationJob.reason
             if (errorMessage !== undefined) {

packages/core/src/codewhisperer/service/transformByQ/transformMavenHandler.ts

@@ -11,7 +11,7 @@ import { spawnSync } from 'child_process' // eslint-disable-line no-restricted-i
 import { CodeTransformBuildCommand, telemetry } from '../../../shared/telemetry/telemetry'
 import { CodeTransformTelemetryState } from '../../../amazonqGumby/telemetry/codeTransformTelemetryState'
 import { ToolkitError } from '../../../shared/errors'
-import { writeLogs } from './transformFileHandler'
+import { setMaven, writeLogs } from './transformFileHandler'
 import { throwIfCancelled } from './transformApiHandler'
 
 // run 'install' with either 'mvnw.cmd', './mvnw', or 'mvn' (if wrapper exists, we use that, otherwise we use regular 'mvn')
@@ -108,6 +108,8 @@ function copyProjectDependencies(dependenciesFolder: FolderInfo, modulePath: str
 }
 
 export async function prepareProjectDependencies(dependenciesFolder: FolderInfo, rootPomPath: string) {
+    await setMaven()
+    getLogger().info('CodeTransformation: running Maven copy-dependencies')
     try {
         copyProjectDependencies(dependenciesFolder, rootPomPath)
     } catch (err) {
@@ -117,6 +119,7 @@ export async function prepareProjectDependencies(dependenciesFolder: FolderInfo,
         )
     }
 
+    getLogger().info('CodeTransformation: running Maven install')
     try {
         installProjectDependencies(dependenciesFolder, rootPomPath)
     } catch (err) {
@@ -134,9 +137,9 @@ export async function prepareProjectDependencies(dependenciesFolder: FolderInfo,
 
 export async function getVersionData() {
     const baseCommand = transformByQState.getMavenName() // will be one of: 'mvnw.cmd', './mvnw', 'mvn'
-    const modulePath = transformByQState.getProjectPath()
+    const projectPath = transformByQState.getProjectPath()
     const args = ['-v']
-    const spawnResult = spawnSync(baseCommand, args, { cwd: modulePath, shell: true, encoding: 'utf-8' })
+    const spawnResult = spawnSync(baseCommand, args, { cwd: projectPath, shell: true, encoding: 'utf-8' })
 
     let localMavenVersion: string | undefined = ''
     let localJavaVersion: string | undefined = ''

packages/core/src/codewhisperer/service/transformByQ/transformationResultsViewProvider.ts

@@ -178,6 +178,7 @@ export class DiffModel {
         }
 
         const changedFiles = parsePatch(diffContents)
+        getLogger().info('CodeTransformation: parsed patch file successfully')
         // path to the directory containing copy of the changed files in the transformed project
         const pathToTmpSrcDir = this.copyProject(pathToWorkspace, changedFiles)
         transformByQState.setProjectCopyFilePath(pathToTmpSrcDir)
@@ -402,6 +403,7 @@ export class ProposedTransformationExplorer {
                         pathToArchive
                     )
 
+                    getLogger().info('CodeTransformation: downloaded results successfully')
                     // Update downloaded artifact size
                     exportResultsArchiveSize = (await fs.promises.stat(pathToArchive)).size
 
@@ -534,6 +536,7 @@ export class ProposedTransformationExplorer {
 
         vscode.commands.registerCommand('aws.amazonq.transformationHub.reviewChanges.acceptChanges', async () => {
             telemetry.codeTransform_submitSelection.run(() => {
+                getLogger().info('CodeTransformation: accepted changes')
                 diffModel.saveChanges()
                 telemetry.record({
                     codeTransformSessionId: CodeTransformTelemetryState.instance.getSessionId(),
@@ -587,6 +590,7 @@ export class ProposedTransformationExplorer {
 
         vscode.commands.registerCommand('aws.amazonq.transformationHub.reviewChanges.rejectChanges', async () => {
             await telemetry.codeTransform_submitSelection.run(async () => {
+                getLogger().info('CodeTransformation: rejected changes')
                 diffModel.rejectChanges()
                 await reset()
                 telemetry.record({