Commit 4b20c5a
authored
refactor(ziputil): remove non-zipping related utilities out of
## Problem
`ZipUtil` contains a mix of different utilities from working with
workspaces, to computing git diffs. These are all used in zipping the
project, but inherently have no connection to it.
Larger problem is that `ZipUtil` is highly coupled to agent
implementations and is difficult to generalize. Moving out non-zipping
noise will help.
## Solution
- Move these utils to more appropriate locations.
- Move the `GitDiff` utilities out of the `ZipUtil` class. These
functions have no test coverage and are therefore unsafe to export or
move to their own file in its current state.
## Future Work
Refactor to avoid references to scope and use case.
---
- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.ZipUtil (aws#6830)1 parent d67aa9d commit 4b20c5a
File tree
9 files changed
+236
-208
lines changed- packages/core/src
- codewhisperer
- commands
- models
- util
- testE2E/codewhisperer
- test
- amazonq/util
- codewhisperer
9 files changed
+236
-208
lines changedLines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
| 53 | + | |
53 | 54 | | |
54 | 55 | | |
55 | 56 | | |
| |||
156 | 157 | | |
157 | 158 | | |
158 | 159 | | |
159 | | - | |
| 160 | + | |
160 | 161 | | |
161 | 162 | | |
162 | 163 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
24 | 25 | | |
25 | 26 | | |
26 | 27 | | |
| |||
48 | 49 | | |
49 | 50 | | |
50 | 51 | | |
51 | | - | |
| 52 | + | |
52 | 53 | | |
53 | 54 | | |
54 | 55 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
926 | 926 | | |
927 | 927 | | |
928 | 928 | | |
| 929 | + | |
| 930 | + | |
| 931 | + | |
| 932 | + | |
0 commit comments