Add the Multiplication Table program in Python folder #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karastoyanov
reviewed
Apr 5, 2023
| print (n,"x",i,"=",(n*i)) | ||
|
|
||
| def main(): | ||
| number = int(input("Enter a no. between 1 to 10: ")) |
Owner
There was a problem hiding this comment.
- Try to implement a IF-statement in case that the user accidently enters a different type instead of integer.
- What will hapen if the user input is bigger than 10 or less than 0? Try to solve this case
karastoyanov
requested changes
Apr 5, 2023
Owner
karastoyanov
left a comment
karastoyanov
left a comment
There was a problem hiding this comment.
The code seems fine. However, few remarks:
-
open the pull request to karastoyanov:development branch instead of the main branch
-
As a bonus try to improve a little bit your code and add some additional features, read my comments in the code.
-
I have opened a separate issue #7 for you, just give it a random comment to be able to assign it for you and check once again the full description of the task.
karastoyanov
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.