Skip to content

Suggestion on create_batches.pyΒ #93

@shenwei356

Description

@shenwei356

Hi Karel, create_batches.py works as expected, here are just some minor suggestions.

  1. In the help message, clustered_fastas.tsv is the input metafile containing file and species column, while its name is kind of misunderstood, I thought it was the output. How about meta_file.tsv.

  2. log output is inaccurate. 1932811 should be 1932812 after checking both the input data and output data.

     Loaded 1932811 genomes across 10357 species clusters
    
  3. Some instruction or notification might be added to tell users to delete the output directory before running this script, cause it does not complain if the output directory is not empty, which might bring some unexpected results.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions