Enhance deployment and destroy workflows with improved logging and resource management

- Added deployment completion messages and application URL output in deploy.yml
- Updated destroy.yml to only delete LoadBalancer services, allowing Terraform to manage ArgoCD application cleanup
- Modified main.tf to set Helm release wait and timeout parameters, ensuring ArgoCD readiness before application creation

Author: karimzakzouk

.github/workflows/destroy.yml

@@ -28,12 +28,11 @@ jobs:
         run: |
           aws eks update-kubeconfig --name otel-cluster --region us-east-1 || true
           
-          # Delete ArgoCD application (this will clean up all Helm resources)
-          kubectl delete application solar-system -n argocd || true
-          
-          # Delete ArgoCD LoadBalancer to avoid Terraform destroy hanging
-          kubectl delete svc argocd-server -n argocd || true   
-                 
+          # Only delete the LoadBalancer services to prevent VPC destruction issues
+          # Let Terraform handle destroying the ArgoCD application it created
+          kubectl delete svc argocd-server -n argocd || true
+          kubectl delete svc solar-system-svc || true
+
       - name: Terraform Init
         run: terraform init
         working-directory: ./Terraform

Terraform/0-versions.tf

@@ -13,5 +13,9 @@ terraform {
       source  = "hashicorp/kubernetes"
       version = "~> 2.25"
     }
+    time = {
+      source  = "hashicorp/time"
+      version = "~> 0.9"
+    }
   }
 }

Terraform/3-main.tf

@@ -26,6 +26,8 @@ resource "helm_release" "argocd" {
   namespace  = "argocd"
 
   create_namespace = true
+  wait             = true
+  timeout          = 600
 
   set {
     name  = "server.service.type"
@@ -39,3 +41,41 @@ resource "helm_release" "argocd" {
 
   depends_on = [module.eks]
 }
+
+# Wait for ArgoCD to be ready before creating applications
+resource "time_sleep" "wait_for_argocd" {
+  depends_on = [helm_release.argocd]
+  create_duration = "60s"
+}
+
+# Create ArgoCD Application automatically
+resource "kubernetes_manifest" "solar_system_app" {
+  manifest = {
+    apiVersion = "argoproj.io/v1alpha1"
+    kind       = "Application"
+    metadata = {
+      name      = "solar-system"
+      namespace = "argocd"
+    }
+    spec = {
+      project = "default"
+      source = {
+        repoURL        = "https://github.com/KarimZakzouk/Graduation-Project-Devops"
+        targetRevision = "HEAD"
+        path           = "helm"
+      }
+      destination = {
+        server    = "https://kubernetes.default.svc"
+        namespace = "default"
+      }
+      syncPolicy = {
+        automated = {
+          prune    = true
+          selfHeal = true
+        }
+      }
+    }
+  }
+
+  depends_on = [time_sleep.wait_for_argocd]
+}