Skip to content

Commit 1b95871

Browse files
committed
Reorder 'Apply Secrets' step in deployment workflow for clarity
1 parent 5fc4289 commit 1b95871

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

.github/workflows/deploy.yml

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -53,20 +53,17 @@ jobs:
5353
run: |
5454
kubectl create namespace ${{ inputs.app_namespace }} --dry-run=client -o yaml | kubectl apply -f -
5555
56-
- name: Apply Secrets
57-
run: |
58-
kubectl create secret generic mongo-secrets \
59-
--from-literal=MONGO_URI="${{ secrets.MONGO_URI }}" \
60-
--from-literal=MONGO_USERNAME="${{ secrets.MONGO_USERNAME }}" \
61-
--from-literal=MONGO_PASSWORD="${{ secrets.MONGO_PASSWORD }}" \
62-
-n ${{ inputs.app_namespace }} --dry-run=client -o yaml | kubectl apply -f -
63-
64-
65-
6656
- name: Deploy ArgoCD Applications
6757
run: |
6858
export APP_NAME=${{ inputs.app_name }}
6959
export APP_NAMESPACE=${{ inputs.app_namespace }}
7060
export ARGOCD_NAMESPACE=${{ inputs.argocd_namespace }}
7161
envsubst < ./argocd/application.yml | kubectl apply -f -
72-
62+
63+
- name: Apply Secrets
64+
run: |
65+
kubectl create secret generic mongo-secrets \
66+
--from-literal=MONGO_URI="${{ secrets.MONGO_URI }}" \
67+
--from-literal=MONGO_USERNAME="${{ secrets.MONGO_USERNAME }}" \
68+
--from-literal=MONGO_PASSWORD="${{ secrets.MONGO_PASSWORD }}" \
69+
-n ${{ inputs.app_namespace }} --dry-run=client -o yaml | kubectl apply -f -

0 commit comments

Comments
 (0)