Skip to content

Commit 8b20f40

Browse files
committed
Refactor ArgoCD Helm release configuration: remove unnecessary extraArgs and clean up comments
1 parent b24ad1f commit 8b20f40

File tree

1 file changed

+5
-11
lines changed

1 file changed

+5
-11
lines changed

Terraform/modules/argocd/main.tf

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ resource "random_password" "dex_secret" {
33
special = true
44
}
55

6-
7-
# Install ArgoCD using Helm
86
resource "helm_release" "argocd" {
7+
depends_on = [random_password.dex_secret]
8+
99
name = "argocd"
1010
repository = "https://argoproj.github.io/argo-helm"
1111
chart = "argo-cd"
@@ -31,11 +31,6 @@ resource "helm_release" "argocd" {
3131
}
3232
}
3333

34-
set {
35-
name = "server.extraArgs[1]"
36-
value = "--grpc-web"
37-
}
38-
3934
# LoadBalancer annotations
4035
set {
4136
name = "server.service.annotations.service\\.beta\\.kubernetes\\.io/aws-load-balancer-type"
@@ -47,14 +42,13 @@ resource "helm_release" "argocd" {
4742
value = "internet-facing"
4843
}
4944

50-
# Dex secret key (production)
51-
set {
45+
# Dex secret key (production)
46+
set {
5247
name = "dex.config.server.secretKey"
5348
value = var.dex_secret_key != null ? var.dex_secret_key : random_password.dex_secret.result
54-
}
49+
}
5550
}
5651

57-
# Wait for ArgoCD to be ready before creating applications
5852
resource "time_sleep" "wait_for_argocd" {
5953
depends_on = [helm_release.argocd]
6054
create_duration = var.wait_for_ready

0 commit comments

Comments
 (0)