Skip to content

Commit d1d6cf5

Browse files
committed
Update deployment and Docker workflows to use secret references for environment variables; fix service URL retrieval in deploy.yml
1 parent 82eebdd commit d1d6cf5

File tree

3 files changed

+26
-5
lines changed

3 files changed

+26
-5
lines changed

.github/workflows/deploy.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,6 @@ jobs:
9999
100100
- name: Get Service URL
101101
run: |
102-
HOSTNAME=$(kubectl get svc solar-system-service -o jsonpath='{.status.loadBalancer.ingress[0].hostname}')
103-
echo "Service URL: http://$HOSTNAME:3000"
102+
HOSTNAME=$(kubectl get svc solar-system-svc -o jsonpath='{.status.loadBalancer.ingress[0].hostname}')
103+
echo "Service URL: http://$HOSTNAME"
104104
working-directory: ./kubernetes

.github/workflows/docker.yml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,17 @@ jobs:
6363
run: |
6464
docker images
6565
66+
# Debug: Check if secrets are available
67+
echo "Checking environment variables:"
68+
echo "MONGO_URI length: ${#MONGO_URI}"
69+
echo "MONGO_USERNAME: $MONGO_USERNAME"
70+
6671
# Start the container
6772
docker run --name solar-system-app -d \
6873
-p 3000:3000 \
69-
-e MONGO_URI=${{ secrets.MONGO_URI }} \
70-
-e MONGO_USERNAME=${{ secrets.MONGO_USERNAME }} \
71-
-e MONGO_PASSWORD=${{ secrets.MONGO_PASSWORD }} \
74+
-e MONGO_URI="$MONGO_URI" \
75+
-e MONGO_USERNAME="$MONGO_USERNAME" \
76+
-e MONGO_PASSWORD="$MONGO_PASSWORD" \
7277
ghcr.io/${{ secrets.DOCKER_USERNAME }}/graduation-project-devops:${{ github.sha }}
7378
7479
# Wait for container to start

helm/templates/deployment.yaml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,3 +18,19 @@ spec:
1818
imagePullPolicy: {{ .Values.image.pullPolicy }}
1919
ports:
2020
- containerPort: {{ .Values.service.targetPort }}
21+
env:
22+
- name: MONGO_URI
23+
valueFrom:
24+
secretKeyRef:
25+
name: mongo-secrets
26+
key: MONGO_URI
27+
- name: MONGO_USERNAME
28+
valueFrom:
29+
secretKeyRef:
30+
name: mongo-secrets
31+
key: MONGO_USERNAME
32+
- name: MONGO_PASSWORD
33+
valueFrom:
34+
secretKeyRef:
35+
name: mongo-secrets
36+
key: MONGO_PASSWORD

0 commit comments

Comments
 (0)