Refactor deployment workflows: remove development workflow, update image tag handling in Docker workflow, and enhance S3 bucket configuration in Terraform

Author: karimzakzouk

.github/workflows/deploy.yml

@@ -64,21 +64,6 @@ jobs:
             --set mongo.username="${{ secrets.MONGO_USERNAME }}" \
             --set mongo.password="${{ secrets.MONGO_PASSWORD }}" \
             --set image.tag="$IMAGE_TAG"
-
-      # ✅ Update values.yaml for ArgoCD tracking
-      - name: Update Helm values with new image tag
-        run: |
-          IMAGE_TAG=${{ inputs.image-tag || github.sha }}
-          sed -i "s|tag: \".*\"|tag: \"$IMAGE_TAG\"|g" ./helm/values.yaml
-          
-      - name: Commit updated image tag
-        run: |
-          git config --local user.email "[email protected]"
-          git config --local user.name "GitHub Action"
-          git add helm/values.yaml
-          git commit -m "Update image tag to ${{ inputs.image-tag || github.sha }}" || exit 0
-          git push https://${{ github.actor }}:${{ secrets.GITHUB_TOKEN }}@github.com/${{ github.repository }}.git
-      
       - name: Create Application Namespace
         run: |
           kubectl create namespace my-app-namespace --dry-run=client -o yaml | kubectl apply -f -

.github/workflows/development.yml

@@ -110,3 +110,14 @@ jobs:
           tags: |
             docker.io/${{ secrets.DOCKER_USERNAME }}/graduation-project-devops:${{ github.sha }}
             ghcr.io/${{ secrets.DOCKER_USERNAME }}/graduation-project-devops:${{ github.sha }}
+      - name: Update Helm values with new image tag
+        run: |
+          sed -i "s|tag: \".*\"|tag: \"${{ github.sha }}\"|g" ./helm/values.yaml
+          
+      - name: Commit updated image tag
+        run: |
+          git config --local user.email "[email protected]"
+          git config --local user.name "GitHub Action"
+          git add helm/values.yaml
+          git commit -m "Update image tag to ${{ github.sha }}" || exit 0
+          git push https://${{ github.actor }}:${{ secrets.GITHUB_TOKEN }}@github.com/${{ github.repository }}.git

.github/workflows/docker.yml

@@ -7,6 +7,8 @@ resource "aws_s3_bucket" "terraform_state" {
   bucket = "solar-system-terraform-state-123456" # change to unique name
   acl    = "private"
 
+  force_destroy = true
+
   versioning {
     enabled = true
   }