Skip to content

Commit e4eabd0

Browse files
committed
Update job dependencies in main pipeline and remove unused namespace creation step in ArgoCD workflow
1 parent 3f09f13 commit e4eabd0

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

.github/workflows/argocd.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,4 @@ jobs:
6464
--namespace ${{ inputs.argocd_namespace }} \
6565
--create-namespace \
6666
--set server.service.type=LoadBalancer \
67-
--wait
68-
69-
- name: Create Application Namespace
70-
run: |
71-
kubectl create namespace ${{ inputs.app_namespace }} --dry-run=client -o yaml | kubectl apply -f -
67+
--wait

.github/workflows/main-pipeline.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ jobs:
182182
# Monitoring - runs first after ArgoCD
183183
monitoring:
184184
name: Deploy Monitoring Stack
185-
needs: [argocd, detect-changes]
185+
needs: [terraform, argocd, detect-changes]
186186
if: |
187187
!cancelled() &&
188188
!inputs.skip-monitoring &&
@@ -209,7 +209,7 @@ jobs:
209209
# Application Deployment - runs after monitoring completes
210210
deployment:
211211
name: Deploy Application
212-
needs: [monitoring, detect-changes]
212+
needs: [terraform, monitoring, detect-changes]
213213
if: |
214214
!cancelled() &&
215215
!inputs.skip-deployment &&
@@ -236,7 +236,7 @@ jobs:
236236
# Show endpoints - runs after deployment completes
237237
show-endpoints:
238238
name: Show Service Endpoints
239-
needs: [detect-changes, deployment, monitoring]
239+
needs: [terraform, detect-changes, deployment, monitoring]
240240
if: |
241241
!cancelled() && (
242242
(github.event_name == 'workflow_dispatch') ||

0 commit comments

Comments
 (0)