Months can be off by one

[joneshf]

It looks like this line:

jsonresume-theme-mocha-responsive/index.js

Line 99 in fd34ae0

return moment(Date.parse(date)).format('MM/YYYY')

sometimes makes the months be off by one. E.g. if the "startDate" is "2020-10", the generated date will be 09/2020. Or if the "startDate" is "2020-10-01", the generated date will be 09/2020

It looks like things would work out if moment was used directly:

> moment(Date.parse("2020-10")).format("MM/YYYY")
"09/2020"
> moment("2020-10").format("MM/YYYY")
"10/2020"
> moment(Date.parse("2020-10-01")).format("MM/YYYY")
"09/2020"
> moment("2020-10-01").format("MM/YYYY")
"10/2020"

Though, I'm not sure if that causes other problems. Thoughts?

[karlitos]

Hi, and thank you for taking time and reporting this issue. I will take look at this soon as I will update the libs of this theme.

[karlitos]

Hi, I finally found some time to look into that issue. I think the problem might be, something similar to this behaviour:

> new Date(Date.parse("2020-1")).getMonth()
0
> new Date(Date.parse("2020-12")).getMonth()
11

But we have 2020 and there should not be any reason to use Moment.js anymore .

I am working on solution which will work completely without Moment.js and also improve the date parsing. In a way, that "2020" won't be reckognized as 01.01.2020

[karlitos]

The issue was fixed in the version 1.1.0

[joneshf]

Thanks for following up on this!

I just tried 1.1.0, but it looks like it still has the off by one error.

I also don't get the same results you do when trying your examples:

> new Date(Date.parse("2020-12")).getMonth()
10

I get the same results in my browser as I do on node 15.

---

As an aside, I don't think the Date.parse is doing anything useful there either. At least, it's not different than:

> new Date("2020-12").getMonth()
10

---

In any case, since moment is gone, maybe the move here is to explicitly parse the date in the format the schema expects: https://github.com/jsonresume/resume-schema/blob/7095651fbbb593d2c5dc2db3095412b170d74d2e/schema.json#L5-L9 ? That should alleviate all of the off by one errors since it's not trying to convert between strings and dates but rather just taking the strings as is. That also shows that the example above with "2020-1" shouldn't work anyway since the month is supposed to be a two digit month.

What do you think?

[karlitos]

I will look into it tomorrow. I am sorry for being too hasty, I wanted to fix some other issues like the dependancy on old handlebars version and so on and did not test the fix throughly.

Interestingly, my output of new Date("2020-12").getMonth() is 11

> new Date("2020-12").getMonth()
< 11

I see your point, that the theme should be compliant with the resume-schema. BUT - in my opinion - a full date is not always useful, when it comes to describing something in your CV.

• It is usually enough to state the years you attended schools/universities
• Does it really matters on which exact date you start/quit some of your jobs or get your certification ?
  ...

For those reasons I would like to support incomplete dates and date-ranges.

[joneshf]

I will look into it tomorrow. I am sorry for being too hasty

No worries. I'm in no rush.

For those reasons I would like to support incomplete dates and date-ranges.

The regex in JSON schema matches three different kinds of dates since v0.1.1. I.e. It will support a date like "2020", "2020-10", or "2020-10-01". It just won't support a date like "2020-1" because it doesn't match the format. If you want to support that format above and beyond the minimum, that doesn't seem like an issue.

There's more discussion at jsonresume/resume-schema#142 if you're interested.

There's also an example of how that regex parses: https://regexr.com/5h7rn. You can see some of the tests showing it working on the different formats.

[karlitos]

Thank you for pointing me to those regular expressions. I implemented them into the date formatDate helper, so now all the YYYY, YYY-MM and YYYY-MM-DD formats are supported. I also implemented some unit test. Can you maybe try them
running npm run test ?

[joneshf]

Sorry, it looks like something happened between 1.1.0 and 1.1.1 where it now errors with:

Error: The source handlebar template file or the stylesheet could not be read.

I don't see any tags, so I'm not sure where 1.1.0 is or where 1.1.1 is. Hopefully that error can help you along.