Limit recommendation query scope for performance

Author: karlomikus

app/Services/CocktailRecommendationService.php

@@ -30,6 +30,14 @@ public function recommend(BarMembership $barMembership, int $limit = 10): Collec
     {
         $barMembership->loadMissing('cocktailFavorites');
 
+        // Limit considerations for performance on large datasets
+        $considerationsLimit = 750;
+
+        // Early exit if no favorites
+        if ($barMembership->cocktailFavorites->isEmpty()) {
+            return collect();
+        }
+
         $excludedCocktailIds = $this->getExcludedCocktails($barMembership);
 
         // Collect all favorite tags
@@ -50,6 +58,7 @@ public function recommend(BarMembership $barMembership, int $limit = 10): Collec
             ->where('ingredients.bar_id', $barMembership->bar_id)
             ->join('ingredients', 'ingredients.id', '=', 'cocktail_ingredients.ingredient_id')
             ->groupBy('ingredient_id')
+            ->limit($considerationsLimit)
             ->get();
 
         // Bar shelf ingredients
@@ -63,6 +72,7 @@ public function recommend(BarMembership $barMembership, int $limit = 10): Collec
             ->whereNotIn('cocktails.id', $excludedCocktailIds)
             ->where('cocktails.bar_id', $barMembership->bar_id)
             ->with('tags', 'ingredients.ingredient', 'images')
+            ->limit($considerationsLimit)
             // ->inRandomOrder()
             ->get();