Skip to content
This repository was archived by the owner on Dec 28, 2023. It is now read-only.

Redundant Mocha Reporter Node <div id="mocha"></div> #225

@chrisbottin

Description

@chrisbottin

Hi,

I've noticed the node <div id="mocha"></div> is created by this plugin whenever I'm running karma in debug mode and the mocha reporter is set to "spec".

This node is only used by the mocha HTML reporter so ...

Should this code

karma-mocha/src/adapter.js

Lines 122 to 125 in bb5be9b

if (isDebugPage && haveMochaConfig(tc) && tc.config.mocha.reporter) {
createMochaReporterNode()
return tc.config.mocha.reporter
}

be changed to check which reporter is used like this?

if (isDebugPage && haveMochaConfig(tc) && tc.config.mocha.reporter === 'html') {
    createMochaReporterNode()
    return tc.config.mocha.reporter
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions