Skip to content

Commit 3c13542

Browse files
authored
Merge pull request #6688 from Mou887/automated-cherry-pick-of-#6647-upstream-release-1.12-1756107444
Fix unreasonable informer stop behavior
2 parents 1336da1 + 2da0b61 commit 3c13542

File tree

5 files changed

+0
-5
lines changed

5 files changed

+0
-5
lines changed

pkg/controllers/federatedhpa/federatedhpa_controller.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -577,7 +577,6 @@ func (c *FHPAController) buildPodInformerForCluster(clusterScaleClient *util.Clu
577577
return nil
578578
}(); err != nil {
579579
klog.Errorf("Failed to sync cache for cluster: %s, error: %v", clusterScaleClient.ClusterName, err)
580-
c.TypedInformerManager.Stop(clusterScaleClient.ClusterName)
581580
return nil, err
582581
}
583582

pkg/controllers/mcs/service_export_controller.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,6 @@ func (c *ServiceExportController) registerInformersAndStart(cluster *clusterv1al
272272
return nil
273273
}(); err != nil {
274274
klog.Errorf("Failed to sync cache for cluster: %s, error: %v", cluster.Name, err)
275-
c.InformerManager.Stop(cluster.Name)
276275
return err
277276
}
278277

pkg/controllers/multiclusterservice/endpointslice_collect_controller.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,6 @@ func (c *EndpointSliceCollectController) registerInformersAndStart(cluster *clus
214214
return nil
215215
}(); err != nil {
216216
klog.Errorf("Failed to sync cache for cluster: %s, error: %v", cluster.Name, err)
217-
c.InformerManager.Stop(cluster.Name)
218217
return err
219218
}
220219

pkg/controllers/status/cluster_status_controller.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,6 @@ func (c *ClusterStatusController) buildInformerForCluster(clusterClient *util.Cl
390390
return nil
391391
}(); err != nil {
392392
klog.Errorf("Failed to sync cache for cluster: %s, error: %v", clusterClient.ClusterName, err)
393-
c.TypedInformerManager.Stop(clusterClient.ClusterName)
394393
return nil, err
395394
}
396395

pkg/controllers/status/work_status_controller.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -504,7 +504,6 @@ func (c *WorkStatusController) registerInformersAndStart(cluster *clusterv1alpha
504504
return nil
505505
}(); err != nil {
506506
klog.Errorf("Failed to sync cache for cluster: %s, error: %v", cluster.Name, err)
507-
c.InformerManager.Stop(cluster.Name)
508507
return err
509508
}
510509

0 commit comments

Comments
 (0)