Skip to content

Commit 52f4459

Browse files
remove failover-eviction-timeout flag in the karmada-controller-manager
Signed-off-by: changzhen <[email protected]>
1 parent bd5692f commit 52f4459

File tree

3 files changed

+0
-7
lines changed

3 files changed

+0
-7
lines changed

artifacts/deploy/karmada-controller-manager.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ spec:
3535
- /bin/karmada-controller-manager
3636
- --kubeconfig=/etc/karmada/config/karmada.config
3737
- --cluster-status-update-frequency=10s
38-
- --failover-eviction-timeout=30s
3938
- --controllers=*,hpaScaleTargetMarker,deploymentReplicasSyncer
4039
- --feature-gates=AllAlpha=true,AllBeta=true
4140
- --metrics-bind-address=$(POD_IP):8080

cmd/controller-manager/app/options/options.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,6 @@ type Options struct {
5454
// ClusterStatusUpdateFrequency is the frequency that controller computes and report cluster status.
5555
// It must work with ClusterMonitorGracePeriod(--cluster-monitor-grace-period) in karmada-controller-manager.
5656
ClusterStatusUpdateFrequency metav1.Duration
57-
// FailoverEvictionTimeout is the grace period for deleting scheduling result on failed clusters.
58-
FailoverEvictionTimeout metav1.Duration
5957
// ClusterLeaseDuration is a duration that candidates for a lease need to wait to force acquire it.
6058
// This is measure against time of last observed lease RenewTime.
6159
ClusterLeaseDuration metav1.Duration
@@ -199,9 +197,6 @@ func (o *Options) AddFlags(flags *pflag.FlagSet, allControllers, disabledByDefau
199197
"Specifies the grace period of allowing a running cluster to be unresponsive before marking it unhealthy.")
200198
flags.DurationVar(&o.ClusterStartupGracePeriod.Duration, "cluster-startup-grace-period", 60*time.Second,
201199
"Specifies the grace period of allowing a cluster to be unresponsive during startup before marking it unhealthy.")
202-
flags.DurationVar(&o.FailoverEvictionTimeout.Duration, "failover-eviction-timeout", 5*time.Minute,
203-
"Specifies the grace period for deleting scheduling result on failed clusters.")
204-
_ = flags.MarkDeprecated("failover-eviction-timeout", "This flag was previously used to control the delay time for the cluster-controller to mark NoExecute taints when detecting cluster failures. Now that the cluster-controller no longer automatically marks NoExecute taints, this flag has become obsolete. It is marked as deprecated instead of being directly removed to maintain backward compatibility and ensure it does not block upgrade processes.")
205200
flags.StringVar(&o.SkippedPropagatingAPIs, "skipped-propagating-apis", "", "Semicolon separated resources that should be skipped from propagating in addition to the default skip list(cluster.karmada.io;policy.karmada.io;work.karmada.io). Supported formats are:\n"+
206201
"<group> for skip resources with a specific API group(e.g. networking.k8s.io),\n"+
207202
"<group>/<version> for skip resources with a specific API version(e.g. networking.k8s.io/v1beta1),\n"+

operator/pkg/controlplane/manifests.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,6 @@ spec:
144144
- /bin/karmada-controller-manager
145145
- --kubeconfig=/etc/karmada/config/karmada.config
146146
- --cluster-status-update-frequency=10s
147-
- --failover-eviction-timeout=30s
148147
- --leader-elect-resource-namespace={{ .SystemNamespace }}
149148
- --metrics-bind-address=$(POD_IP):8080
150149
- --health-probe-bind-address=$(POD_IP):10357

0 commit comments

Comments
 (0)