add unit test

Signed-off-by: LivingCcj <[email protected]>

Author: LivingCcj

pkg/scheduler/core/assignment_test.go

@@ -416,6 +416,40 @@ func Test_dynamicScale(t *testing.T) {
 			},
 			wantErr: false,
 		},
+		{
+			name: "replica 12 -> 24, dynamic weighted 10:10(unhealthy cluster):10",
+			candidates: []spreadconstraint.ClusterDetailInfo{
+				{Name: ClusterMember1, Cluster: helper.NewClusterWithResource(ClusterMember1, corev1.ResourceList{
+					corev1.ResourcePods: *resource.NewQuantity(10, resource.DecimalSI),
+				}, util.EmptyResource().ResourceList(), util.EmptyResource().ResourceList()), AllocatableReplicas: 10},
+				{Name: ClusterMember2, Cluster: helper.NewClusterWithUnhealthyStatus(ClusterMember2, corev1.ResourceList{
+					corev1.ResourcePods: *resource.NewQuantity(10, resource.DecimalSI),
+				}, util.EmptyResource().ResourceList(), util.EmptyResource().ResourceList()), AllocatableReplicas: 10},
+				{Name: ClusterMember3, Cluster: helper.NewClusterWithResource(ClusterMember3, corev1.ResourceList{
+					corev1.ResourcePods: *resource.NewQuantity(10, resource.DecimalSI),
+				}, util.EmptyResource().ResourceList(), util.EmptyResource().ResourceList()), AllocatableReplicas: 10},
+			},
+			object: &workv1alpha2.ResourceBindingSpec{
+				ReplicaRequirements: &workv1alpha2.ReplicaRequirements{
+					ResourceRequest: util.EmptyResource().ResourceList(),
+				},
+				Replicas: 24,
+				Clusters: []workv1alpha2.TargetCluster{
+					{Name: ClusterMember1, Replicas: 2},
+					{Name: ClusterMember2, Replicas: 4},
+					{Name: ClusterMember3, Replicas: 6},
+				},
+				Placement: &policyv1alpha1.Placement{
+					ReplicaScheduling: dynamicWeightStrategy,
+				},
+			},
+			want: []workv1alpha2.TargetCluster{
+				{Name: ClusterMember1, Replicas: 8},
+				{Name: ClusterMember2, Replicas: 4},
+				{Name: ClusterMember3, Replicas: 12},
+			},
+			wantErr: false,
+		},
 		{
 			name: "replica 12 -> 24, dynamic weighted 1:1:1",
 			candidates: []spreadconstraint.ClusterDetailInfo{

test/helper/resource.go

@@ -679,6 +679,17 @@ func MakeNodeWithTaints(node string, milliCPU, memory, pods, ephemeralStorage in
 func NewCluster(name string) *clusterv1alpha1.Cluster {
 	return &clusterv1alpha1.Cluster{
 		ObjectMeta: metav1.ObjectMeta{Name: name},
+		Status: clusterv1alpha1.ClusterStatus{
+			Conditions: []metav1.Condition{
+				{
+					Type:               clusterv1alpha1.ClusterConditionReady,
+					Status:             metav1.ConditionTrue,
+					Reason:             "ClusterReady",
+					Message:            "cluster is healthy and ready to accept workloads",
+					LastTransitionTime: metav1.Now(),
+				},
+			},
+		},
 	}
 }
 
@@ -692,6 +703,38 @@ func NewClusterWithResource(name string, allocatable, allocating, allocated core
 				Allocating:  allocating,
 				Allocated:   allocated,
 			},
+			Conditions: []metav1.Condition{
+				{
+					Type:               clusterv1alpha1.ClusterConditionReady,
+					Status:             metav1.ConditionTrue,
+					Reason:             "ClusterReady",
+					Message:            "cluster is healthy and ready to accept workloads",
+					LastTransitionTime: metav1.Now(),
+				},
+			},
+		},
+	}
+}
+
+// NewClusterWithUnhealthyStatus will build a Cluster with resource.
+func NewClusterWithUnhealthyStatus(name string, allocatable, allocating, allocated corev1.ResourceList) *clusterv1alpha1.Cluster {
+	return &clusterv1alpha1.Cluster{
+		ObjectMeta: metav1.ObjectMeta{Name: name},
+		Status: clusterv1alpha1.ClusterStatus{
+			ResourceSummary: &clusterv1alpha1.ResourceSummary{
+				Allocatable: allocatable,
+				Allocating:  allocating,
+				Allocated:   allocated,
+			},
+			Conditions: []metav1.Condition{
+				{
+					Type:               clusterv1alpha1.ClusterConditionReady,
+					Status:             metav1.ConditionFalse,
+					Reason:             "ClusterNotReachable",
+					Message:            "cluster is not reachable",
+					LastTransitionTime: metav1.Now(),
+				},
+			},
 		},
 	}
 }