Skip to content

Commit 6efd86b

Browse files
committed
Fix unreasonable informer stop behavior
Signed-off-by: zhzhuang-zju <[email protected]>
1 parent dfdd9a5 commit 6efd86b

File tree

5 files changed

+0
-5
lines changed

5 files changed

+0
-5
lines changed

pkg/controllers/federatedhpa/federatedhpa_controller.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -577,7 +577,6 @@ func (c *FHPAController) buildPodInformerForCluster(clusterScaleClient *util.Clu
577577
return nil
578578
}(); err != nil {
579579
klog.ErrorS(err, "Failed to sync cache for cluster", "cluster", clusterScaleClient.ClusterName)
580-
c.TypedInformerManager.Stop(clusterScaleClient.ClusterName)
581580
return nil, err
582581
}
583582

pkg/controllers/mcs/service_export_controller.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,6 @@ func (c *ServiceExportController) registerInformersAndStart(cluster *clusterv1al
285285
return nil
286286
}(); err != nil {
287287
klog.ErrorS(err, "Failed to sync cache for cluster", "cluster", cluster.Name)
288-
c.InformerManager.Stop(cluster.Name)
289288
return err
290289
}
291290

pkg/controllers/multiclusterservice/endpointslice_collect_controller.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,6 @@ func (c *EndpointSliceCollectController) registerInformersAndStart(cluster *clus
224224
return nil
225225
}(); err != nil {
226226
klog.ErrorS(err, "Failed to sync cache for cluster", "cluster", cluster.Name)
227-
c.InformerManager.Stop(cluster.Name)
228227
return err
229228
}
230229

pkg/controllers/status/cluster_status_controller.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,6 @@ func (c *ClusterStatusController) buildInformerForCluster(clusterClient *util.Cl
390390
return nil
391391
}(); err != nil {
392392
klog.ErrorS(err, "Failed to sync cache for cluster", "cluster", clusterClient.ClusterName)
393-
c.TypedInformerManager.Stop(clusterClient.ClusterName)
394393
return nil, err
395394
}
396395

pkg/controllers/status/work_status_controller.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,6 @@ func (c *WorkStatusController) registerInformersAndStart(cluster *clusterv1alpha
498498
return nil
499499
}(); err != nil {
500500
klog.ErrorS(err, "Failed to sync cache for cluster", "cluster", cluster.Name)
501-
c.InformerManager.Stop(cluster.Name)
502501
return err
503502
}
504503

0 commit comments

Comments
 (0)