Skip to content

Commit 9444460

Browse files
committed
karmadactl: set default 5s timeout for resource completion
1 parent 3424bc7 commit 9444460

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

pkg/karmadactl/util/completion/completion.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,11 @@ func compGetResourceList(restClientGetter genericclioptions.RESTClientGetter, cm
256256
o.PrintFlags.OutputFormat = ptr.To("name")
257257
o.Cached = true
258258
o.Verbs = []string{"get"}
259-
// TODO: Should set --request-timeout=5s
259+
if configFlags, ok := restClientGetter.(*genericclioptions.ConfigFlags); ok {
260+
if configFlags.Timeout == nil || len(*configFlags.Timeout) == 0 {
261+
configFlags.Timeout = ptr.To("5s")
262+
}
263+
}
260264

261265
if err := o.Complete(restClientGetter, cmd, nil); err != nil {
262266
return nil

0 commit comments

Comments
 (0)