Skip to content

Commit a573ddf

Browse files
authored
Merge pull request #7085 from FAUST-BENCHOU/fix/force-flag
cleanup: remove useless TODOs
2 parents b30634c + 4f31161 commit a573ddf

File tree

3 files changed

+0
-7
lines changed

3 files changed

+0
-7
lines changed

pkg/estimator/server/estimate.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,6 @@ func (es *AccurateSchedulerEstimatorServer) estimateComponents(ctx context.Conte
102102
return maxSets, fmt.Errorf("estimate components plugins fails with %s", ret.Reasons())
103103
}
104104

105-
// TODO - Node info has not be included in this implementation. Node Resource Estimation will be moved to a separate plugin.
106-
107105
// If no plugins were run (NoOperation), return maxSets value to prevent scheduling failure
108106
if ret.IsSuccess() || ret.IsNoOperation() {
109107
return maxSets, nil

pkg/karmadactl/interpret/edit.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -166,13 +166,9 @@ func (o *Options) runEdit() error {
166166
file: file,
167167
}
168168

169-
// TODO: validate edited customization
170-
171169
// not a syntax error as it turns out...
172170
containsError = false
173171

174-
// TODO: add last-applied-configuration annotation
175-
176172
switch {
177173
case info.Source != "":
178174
err = o.saveToPath(info, editedCustomization, &results)

pkg/karmadactl/unregister/unregister.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,6 @@ func (j *CommandUnregisterOption) RunUnregisterCluster() error {
339339
j.Wait = j.Wait - time.Since(start)
340340

341341
// 2. delete the cluster object from the Karmada control plane
342-
// TODO: add flag --force to implement force deletion.
343342
if err = cmdutil.DeleteClusterObject(j.ControlPlaneKubeClient, j.ControlPlaneClient, j.ClusterName, j.Wait, j.DryRun, false); err != nil {
344343
klog.Errorf("Failed to delete cluster object. cluster name: %s, error: %v", j.ClusterName, err)
345344
return err

0 commit comments

Comments
 (0)