Merge pull request #6907 from zhzhuang-zju/flaky

flaky test: deploy workloads should be rejected in case of no enough quota left

Author: karmada-bot

test/e2e/framework/federatedresourcequota.go

@@ -26,6 +26,7 @@ import (
 	"github.com/onsi/gomega"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/types"
+	"k8s.io/klog/v2"
 
 	policyv1alpha1 "github.com/karmada-io/karmada/pkg/apis/policy/v1alpha1"
 	karmada "github.com/karmada-io/karmada/pkg/generated/clientset/versioned"
@@ -89,3 +90,18 @@ func WaitFederatedResourceQuotaCollectStatus(client karmada.Interface, namespace
 		}, PollTimeout, PollInterval).Should(gomega.Equal(true))
 	})
 }
+
+// WaitFederatedResourceQuotaFitWith wait FederatedResourceQuota fit condition.
+func WaitFederatedResourceQuotaFitWith(client karmada.Interface, namespace, name string, fit func(frq *policyv1alpha1.FederatedResourceQuota) bool) {
+	ginkgo.By(fmt.Sprintf("Waiting for FederatedResourceQuota %s/%s to fit condition", namespace, name), func() {
+		gomega.Eventually(func() bool {
+			frq, err := client.PolicyV1alpha1().FederatedResourceQuotas(namespace).Get(context.TODO(), name, metav1.GetOptions{})
+			if err != nil {
+				klog.Errorf("Failed to get FederatedResourceQuota(%s/%s), err: %v", namespace, name, err)
+				return false
+			}
+
+			return fit(frq)
+		}, PollTimeout, PollInterval).Should(gomega.Equal(true))
+	})
+}

test/e2e/suites/base/federatedresourcequota_test.go

@@ -304,6 +304,11 @@ var _ = ginkgo.Describe("FederatedResourceQuota enforcement testing", func() {
 				}
 				federatedResourceQuota = helper.NewFederatedResourceQuotaWithOverall(frqNamespace, frqName, overall)
 				framework.CreateFederatedResourceQuota(karmadaClient, federatedResourceQuota)
+				framework.WaitFederatedResourceQuotaFitWith(karmadaClient, frqNamespace, frqName, func(frq *policyv1alpha1.FederatedResourceQuota) bool {
+					// To avoid race condition, ensure that OverallUsed is not nil first, and then deployment can be created.
+					// MoreInfo can refer to https://github.com/karmada-io/karmada/pull/6876#issuecomment-3455446833.
+					return frq.Status.Overall != nil
+				})
 				ginkgo.DeferCleanup(func() {
 					framework.RemoveFederatedResourceQuota(karmadaClient, frqNamespace, frqName)
 				})