Skip to content

Commit bcb3b08

Browse files
Bhaumik10Bhaumik10
committed
JSON logging for multiclusterservice controllers
Signed-off-by: Bhaumik Patel <[email protected]> Address comments Signed-off-by: Bhaumik Patel <[email protected]> Address comments Address comments Address comments
1 parent c60a2e0 commit bcb3b08

File tree

3 files changed

+90
-87
lines changed

3 files changed

+90
-87
lines changed

‎pkg/controllers/multiclusterservice/endpointslice_collect_controller.go‎

Lines changed: 29 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ package multiclusterservice
1818

1919
import (
2020
"context"
21+
"errors"
2122
"fmt"
2223
"reflect"
2324
"strings"
@@ -84,7 +85,7 @@ const EndpointSliceCollectControllerName = "endpointslice-collect-controller"
8485

8586
// Reconcile performs a full reconciliation for the object referred to by the Request.
8687
func (c *EndpointSliceCollectController) Reconcile(ctx context.Context, req controllerruntime.Request) (controllerruntime.Result, error) {
87-
klog.V(4).Infof("Reconciling Work %s", req.NamespacedName.String())
88+
klog.V(4).InfoS("Reconciling Work", "namespace", req.Namespace, "name", req.Name)
8889

8990
work := &workv1alpha1.Work{}
9091
if err := c.Client.Get(ctx, req.NamespacedName, work); err != nil {
@@ -105,7 +106,7 @@ func (c *EndpointSliceCollectController) Reconcile(ctx context.Context, req cont
105106

106107
clusterName, err := names.GetClusterName(work.Namespace)
107108
if err != nil {
108-
klog.Errorf("Failed to get cluster name for work %s/%s", work.Namespace, work.Name)
109+
klog.ErrorS(err, "Failed to get cluster name for work", "namespace", work.Namespace, "name", work.Name)
109110
return controllerruntime.Result{}, err
110111
}
111112

@@ -144,14 +145,15 @@ func (c *EndpointSliceCollectController) collectEndpointSlice(key util.QueueKey)
144145
ctx := context.Background()
145146
fedKey, ok := key.(keys.FederatedKey)
146147
if !ok {
147-
klog.Errorf("Failed to collect endpointslice as invalid key: %v", key)
148+
var ErrInvalidKey = errors.New("invalid key")
149+
klog.ErrorS(ErrInvalidKey, "Failed to collect endpointslice as invalid key", "key", key)
148150
return fmt.Errorf("invalid key")
149151
}
150152

151-
klog.V(4).Infof("Begin to collect %s %s.", fedKey.Kind, fedKey.NamespaceKey())
153+
klog.V(4).InfoS("Begin to collect", "kind", fedKey.Kind, "namespaceKey", fedKey.NamespaceKey())
152154
if err := c.handleEndpointSliceEvent(ctx, fedKey); err != nil {
153-
klog.Errorf("Failed to handle endpointSlice(%s) event, Error: %v",
154-
fedKey.NamespaceKey(), err)
155+
klog.ErrorS(err, "Failed to handle endpointSlice event", "namespaceKey",
156+
fedKey.NamespaceKey())
155157
return err
156158
}
157159

@@ -161,17 +163,18 @@ func (c *EndpointSliceCollectController) collectEndpointSlice(key util.QueueKey)
161163
func (c *EndpointSliceCollectController) buildResourceInformers(clusterName string) error {
162164
cluster, err := util.GetCluster(c.Client, clusterName)
163165
if err != nil {
164-
klog.Errorf("Failed to get the given member cluster %s", clusterName)
166+
klog.ErrorS(err, "Failed to get the given member cluster", "cluster", clusterName)
165167
return err
166168
}
167169

168170
if !util.IsClusterReady(&cluster.Status) {
169-
klog.Errorf("Stop collect endpointslice for cluster(%s) as cluster not ready.", cluster.Name)
171+
var ErrClusterNotReady = errors.New("cluster not ready")
172+
klog.ErrorS(ErrClusterNotReady, "Stop collect endpointslice for cluster as cluster not ready.", "cluster", cluster.Name)
170173
return fmt.Errorf("cluster(%s) not ready", cluster.Name)
171174
}
172175

173176
if err := c.registerInformersAndStart(cluster); err != nil {
174-
klog.Errorf("Failed to register informer for Cluster %s. Error: %v.", cluster.Name, err)
177+
klog.ErrorS(err, "Failed to register informer for Cluster", "cluster", cluster.Name)
175178
return err
176179
}
177180

@@ -185,7 +188,7 @@ func (c *EndpointSliceCollectController) registerInformersAndStart(cluster *clus
185188
if singleClusterInformerManager == nil {
186189
dynamicClusterClient, err := c.ClusterDynamicClientSetFunc(cluster.Name, c.Client, c.ClusterClientOption)
187190
if err != nil {
188-
klog.Errorf("Failed to build dynamic cluster client for cluster %s.", cluster.Name)
191+
klog.ErrorS(err, "Failed to build dynamic cluster client for cluster", "cluster", cluster.Name)
189192
return err
190193
}
191194
singleClusterInformerManager = c.InformerManager.ForCluster(dynamicClusterClient.ClusterName, dynamicClusterClient.DynamicClientSet, 0)
@@ -220,7 +223,7 @@ func (c *EndpointSliceCollectController) registerInformersAndStart(cluster *clus
220223
}
221224
return nil
222225
}(); err != nil {
223-
klog.Errorf("Failed to sync cache for cluster: %s, error: %v", cluster.Name, err)
226+
klog.ErrorS(err, "Failed to sync cache for cluster", "cluster", cluster.Name)
224227
c.InformerManager.Stop(cluster.Name)
225228
return err
226229
}
@@ -245,7 +248,7 @@ func (c *EndpointSliceCollectController) genHandlerAddFunc(clusterName string) f
245248
curObj := obj.(runtime.Object)
246249
key, err := keys.FederatedKeyFunc(clusterName, curObj)
247250
if err != nil {
248-
klog.Warningf("Failed to generate key for obj: %s", curObj.GetObjectKind().GroupVersionKind())
251+
klog.ErrorS(err, "Failed to generate key for obj", "gvk", curObj.GetObjectKind().GroupVersionKind())
249252
return
250253
}
251254
c.worker.Add(key)
@@ -258,7 +261,7 @@ func (c *EndpointSliceCollectController) genHandlerUpdateFunc(clusterName string
258261
if !reflect.DeepEqual(oldObj, newObj) {
259262
key, err := keys.FederatedKeyFunc(clusterName, curObj)
260263
if err != nil {
261-
klog.Warningf("Failed to generate key for obj: %s", curObj.GetObjectKind().GroupVersionKind())
264+
klog.ErrorS(err, "Failed to generate key for obj", "gvk", curObj.GetObjectKind().GroupVersionKind())
262265
return
263266
}
264267
c.worker.Add(key)
@@ -278,7 +281,7 @@ func (c *EndpointSliceCollectController) genHandlerDeleteFunc(clusterName string
278281
oldObj := obj.(runtime.Object)
279282
key, err := keys.FederatedKeyFunc(clusterName, oldObj)
280283
if err != nil {
281-
klog.Warningf("Failed to generate key for obj: %s", oldObj.GetObjectKind().GroupVersionKind())
284+
klog.ErrorS(err, "Failed to generate key for obj", "gvk", oldObj.GetObjectKind().GroupVersionKind())
282285
return
283286
}
284287
c.worker.Add(key)
@@ -308,7 +311,7 @@ func (c *EndpointSliceCollectController) handleEndpointSliceEvent(ctx context.Co
308311
util.MultiClusterServiceNamespaceLabel: endpointSliceKey.Namespace,
309312
util.MultiClusterServiceNameLabel: util.GetLabelValue(endpointSliceObj.GetLabels(), discoveryv1.LabelServiceName),
310313
})}); err != nil {
311-
klog.Errorf("Failed to list workList reported by endpointSlice(%s/%s), error: %v", endpointSliceKey.Namespace, endpointSliceKey.Name, err)
314+
klog.ErrorS(err, "Failed to list workList reported by endpointSlice", "namespace", endpointSliceKey.Namespace, "name", endpointSliceKey.Name)
312315
return err
313316
}
314317

@@ -324,8 +327,8 @@ func (c *EndpointSliceCollectController) handleEndpointSliceEvent(ctx context.Co
324327
}
325328

326329
if err = c.reportEndpointSliceWithEndpointSliceCreateOrUpdate(ctx, endpointSliceKey.Cluster, endpointSliceObj); err != nil {
327-
klog.Errorf("Failed to handle endpointSlice(%s) event, Error: %v",
328-
endpointSliceKey.NamespaceKey(), err)
330+
klog.ErrorS(err, "Failed to handle endpointSlice event", "namespaceKey",
331+
endpointSliceKey.NamespaceKey())
329332
return err
330333
}
331334

@@ -336,7 +339,7 @@ func (c *EndpointSliceCollectController) collectTargetEndpointSlice(ctx context.
336339
manager := c.InformerManager.GetSingleClusterManager(clusterName)
337340
if manager == nil {
338341
err := fmt.Errorf("failed to get informer manager for cluster %s", clusterName)
339-
klog.Errorf("%v", err)
342+
klog.ErrorS(err, "Failed to get informer manager for cluster")
340343
return err
341344
}
342345

@@ -347,21 +350,21 @@ func (c *EndpointSliceCollectController) collectTargetEndpointSlice(ctx context.
347350
})
348351
epsList, err := manager.Lister(discoveryv1.SchemeGroupVersion.WithResource("endpointslices")).ByNamespace(svcNamespace).List(selector)
349352
if err != nil {
350-
klog.Errorf("Failed to list EndpointSlice for Service(%s/%s) in cluster(%s), Error: %v", svcNamespace, svcName, clusterName, err)
353+
klog.ErrorS(err, "Failed to list EndpointSlice for Service in a cluster", "namespace", svcNamespace, "name", svcName, "cluster", clusterName)
351354
return err
352355
}
353356
for _, epsObj := range epsList {
354357
eps := &discoveryv1.EndpointSlice{}
355358
if err = helper.ConvertToTypedObject(epsObj, eps); err != nil {
356-
klog.Errorf("Failed to convert object to EndpointSlice, error: %v", err)
359+
klog.ErrorS(err, "Failed to convert object to EndpointSlice")
357360
return err
358361
}
359362
if util.GetLabelValue(eps.GetLabels(), discoveryv1.LabelManagedBy) == util.EndpointSliceDispatchControllerLabelValue {
360363
continue
361364
}
362365
epsUnstructured, err := helper.ToUnstructured(eps)
363366
if err != nil {
364-
klog.Errorf("Failed to convert EndpointSlice %s/%s to unstructured, error: %v", eps.GetNamespace(), eps.GetName(), err)
367+
klog.ErrorS(err, "Failed to convert EndpointSlice to unstructured", "namespace", eps.GetNamespace(), "name", eps.GetName())
365368
return err
366369
}
367370
if err = c.reportEndpointSliceWithEndpointSliceCreateOrUpdate(ctx, clusterName, epsUnstructured); err != nil {
@@ -394,7 +397,7 @@ func reportEndpointSlice(ctx context.Context, c client.Client, endpointSlice *un
394397

395398
// indicate the Work should be not propagated since it's collected resource.
396399
if err := ctrlutil.CreateOrUpdateWork(ctx, c, workMeta, endpointSlice, ctrlutil.WithSuspendDispatching(true)); err != nil {
397-
klog.Errorf("Failed to create or update work(%s/%s), Error: %v", workMeta.Namespace, workMeta.Name, err)
400+
klog.ErrorS(err, "Failed to create or update work", "namespace", workMeta.Namespace, "name", workMeta.Name)
398401
return err
399402
}
400403

@@ -408,7 +411,7 @@ func getEndpointSliceWorkMeta(ctx context.Context, c client.Client, ns string, w
408411
Namespace: ns,
409412
Name: workName,
410413
}, existWork); err != nil && !apierrors.IsNotFound(err) {
411-
klog.Errorf("Get EndpointSlice work(%s/%s) error:%v", ns, workName, err)
414+
klog.ErrorS(err, "Get EndpointSlice work", "namespace", ns, "name", workName)
412415
return metav1.ObjectMeta{}, err
413416
}
414417

@@ -449,7 +452,7 @@ func cleanupWorkWithEndpointSliceDelete(ctx context.Context, c client.Client, en
449452
if apierrors.IsNotFound(err) {
450453
return nil
451454
}
452-
klog.Errorf("Failed to get work(%s) in executionSpace(%s): %v", workNamespaceKey.String(), executionSpace, err)
455+
klog.ErrorS(err, "Failed to get work in executionSpace", "namespaceKey", workNamespaceKey.String(), "executionSpace", executionSpace)
453456
return err
454457
}
455458

@@ -472,14 +475,14 @@ func cleanProviderClustersEndpointSliceWork(ctx context.Context, c client.Client
472475
work.Labels[util.EndpointSliceWorkManagedByLabel] = strings.Join(controllerSet.UnsortedList(), ".")
473476

474477
if err := c.Update(ctx, work); err != nil {
475-
klog.Errorf("Failed to update work(%s/%s): %v", work.Namespace, work.Name, err)
478+
klog.ErrorS(err, "Failed to update work", "namespace", work.Namespace, "name", work.Name)
476479
return err
477480
}
478481
return nil
479482
}
480483

481484
if err := c.Delete(ctx, work); err != nil {
482-
klog.Errorf("Failed to delete work(%s/%s): %v", work.Namespace, work.Name, err)
485+
klog.ErrorS(err, "Failed to delete work", "namespace", work.Namespace, "name", work.Name)
483486
return err
484487
}
485488

‎pkg/controllers/multiclusterservice/endpointslice_dispatch_controller.go‎

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ type EndpointsliceDispatchController struct {
6666

6767
// Reconcile performs a full reconciliation for the object referred to by the Request.
6868
func (c *EndpointsliceDispatchController) Reconcile(ctx context.Context, req controllerruntime.Request) (controllerruntime.Result, error) {
69-
klog.V(4).Infof("Reconciling Work %s", req.NamespacedName.String())
69+
klog.V(4).InfoS("Reconciling Work", "namespacedName", req.NamespacedName.String())
7070

7171
work := &workv1alpha1.Work{}
7272
if err := c.Client.Get(ctx, req.NamespacedName, work); err != nil {
@@ -83,7 +83,7 @@ func (c *EndpointsliceDispatchController) Reconcile(ctx context.Context, req con
8383
mcsName := util.GetLabelValue(work.Labels, util.MultiClusterServiceNameLabel)
8484
if !work.DeletionTimestamp.IsZero() || mcsName == "" {
8585
if err := c.cleanupEndpointSliceFromConsumerClusters(ctx, work); err != nil {
86-
klog.Errorf("Failed to cleanup EndpointSlice from consumer clusters for work %s/%s:%v", work.Namespace, work.Name, err)
86+
klog.ErrorS(err, "Failed to cleanup EndpointSlice from consumer clusters for work", "namespace", work.Namespace, "name", work.Name)
8787
return controllerruntime.Result{}, err
8888
}
8989
return controllerruntime.Result{}, nil
@@ -93,7 +93,7 @@ func (c *EndpointsliceDispatchController) Reconcile(ctx context.Context, req con
9393
mcs := &networkingv1alpha1.MultiClusterService{}
9494
if err := c.Client.Get(ctx, types.NamespacedName{Namespace: mcsNS, Name: mcsName}, mcs); err != nil {
9595
if apierrors.IsNotFound(err) {
96-
klog.Warningf("MultiClusterService %s/%s is not found", mcsNS, mcsName)
96+
klog.ErrorS(err, "MultiClusterService is not found", "namespace", mcsNS, "name", mcsName)
9797
return controllerruntime.Result{}, nil
9898
}
9999
return controllerruntime.Result{}, err
@@ -185,15 +185,15 @@ func (c *EndpointsliceDispatchController) newClusterFunc() handler.MapFunc {
185185

186186
mcsList := &networkingv1alpha1.MultiClusterServiceList{}
187187
if err := c.Client.List(ctx, mcsList, &client.ListOptions{}); err != nil {
188-
klog.Errorf("Failed to list MultiClusterService, error: %v", err)
188+
klog.ErrorS(err, "Failed to list MultiClusterService")
189189
return nil
190190
}
191191

192192
var requests []reconcile.Request
193193
for _, mcs := range mcsList.Items {
194194
clusterSet, err := helper.GetConsumerClusters(c.Client, mcs.DeepCopy())
195195
if err != nil {
196-
klog.Errorf("Failed to get provider clusters, error: %v", err)
196+
klog.ErrorS(err, "Failed to get provider clusters")
197197
continue
198198
}
199199

@@ -203,7 +203,7 @@ func (c *EndpointsliceDispatchController) newClusterFunc() handler.MapFunc {
203203

204204
workList, err := c.getClusterEndpointSliceWorks(ctx, mcs.Namespace, mcs.Name)
205205
if err != nil {
206-
klog.Errorf("Failed to list work, error: %v", err)
206+
klog.ErrorS(err, "Failed to list work")
207207
continue
208208
}
209209
for _, work := range workList {
@@ -229,7 +229,7 @@ func (c *EndpointsliceDispatchController) getClusterEndpointSliceWorks(ctx conte
229229
util.MultiClusterServiceNamespaceLabel: mcsNamespace,
230230
}),
231231
}); err != nil {
232-
klog.Errorf("Failed to list work, error: %v", err)
232+
klog.ErrorS(err, "Failed to list work")
233233
return nil, err
234234
}
235235

@@ -249,7 +249,7 @@ func (c *EndpointsliceDispatchController) newMultiClusterServiceFunc() handler.M
249249

250250
workList, err := c.getClusterEndpointSliceWorks(ctx, mcsNamespace, mcsName)
251251
if err != nil {
252-
klog.Errorf("Failed to list work, error: %v", err)
252+
klog.ErrorS(err, "Failed to list work")
253253
return nil
254254
}
255255

@@ -273,7 +273,7 @@ func (c *EndpointsliceDispatchController) cleanOrphanDispatchedEndpointSlice(ctx
273273
util.MultiClusterServiceNameLabel: mcs.Name,
274274
util.MultiClusterServiceNamespaceLabel: mcs.Namespace,
275275
})}); err != nil {
276-
klog.Errorf("Failed to list works, error is: %v", err)
276+
klog.ErrorS(err, "Failed to list works")
277277
return err
278278
}
279279

@@ -285,13 +285,13 @@ func (c *EndpointsliceDispatchController) cleanOrphanDispatchedEndpointSlice(ctx
285285

286286
consumerClusters, err := helper.GetConsumerClusters(c.Client, mcs)
287287
if err != nil {
288-
klog.Errorf("Failed to get consumer clusters, error is: %v", err)
288+
klog.ErrorS(err, "Failed to get consumer clusters")
289289
return err
290290
}
291291

292292
cluster, err := names.GetClusterName(work.Namespace)
293293
if err != nil {
294-
klog.Errorf("Failed to get cluster name for work %s/%s", work.Namespace, work.Name)
294+
klog.ErrorS(err, "Failed to get cluster name for work", "namespace", work.Namespace, "name", work.Name)
295295
return err
296296
}
297297

@@ -300,7 +300,7 @@ func (c *EndpointsliceDispatchController) cleanOrphanDispatchedEndpointSlice(ctx
300300
}
301301

302302
if err = c.Client.Delete(ctx, work.DeepCopy()); err != nil {
303-
klog.Errorf("Failed to delete work %s/%s, error is: %v", work.Namespace, work.Name, err)
303+
klog.ErrorS(err, "Failed to delete work", "namespace", work.Namespace, "name", work.Name)
304304
return err
305305
}
306306
}
@@ -311,13 +311,13 @@ func (c *EndpointsliceDispatchController) cleanOrphanDispatchedEndpointSlice(ctx
311311
func (c *EndpointsliceDispatchController) dispatchEndpointSlice(ctx context.Context, work *workv1alpha1.Work, mcs *networkingv1alpha1.MultiClusterService) error {
312312
epsSourceCluster, err := names.GetClusterName(work.Namespace)
313313
if err != nil {
314-
klog.Errorf("Failed to get EndpointSlice source cluster name for work %s/%s", work.Namespace, work.Name)
314+
klog.ErrorS(err, "Failed to get EndpointSlice source cluster name for work", "namespace", work.Namespace, "name", work.Name)
315315
return err
316316
}
317317

318318
consumerClusters, err := helper.GetConsumerClusters(c.Client, mcs)
319319
if err != nil {
320-
klog.Errorf("Failed to get consumer clusters, error is: %v", err)
320+
klog.ErrorS(err, "Failed to get consumer clusters")
321321
return err
322322
}
323323
for clusterName := range consumerClusters {
@@ -330,7 +330,7 @@ func (c *EndpointsliceDispatchController) dispatchEndpointSlice(ctx context.Cont
330330
c.EventRecorder.Eventf(mcs, corev1.EventTypeWarning, events.EventReasonClusterNotFound, "Consumer cluster %s is not found", clusterName)
331331
continue
332332
}
333-
klog.Errorf("Failed to get cluster %s, error is: %v", clusterName, err)
333+
klog.ErrorS(err, "Failed to get cluster", "cluster", clusterName)
334334
return err
335335
}
336336
if !util.IsClusterReady(&clusterObj.Status) {
@@ -361,13 +361,13 @@ func (c *EndpointsliceDispatchController) ensureEndpointSliceWork(ctx context.Co
361361
manifest := work.Spec.Workload.Manifests[0]
362362
unstructuredObj := &unstructured.Unstructured{}
363363
if err := unstructuredObj.UnmarshalJSON(manifest.Raw); err != nil {
364-
klog.Errorf("Failed to unmarshal work manifest, error is: %v", err)
364+
klog.ErrorS(err, "Failed to unmarshal work manifest")
365365
return err
366366
}
367367

368368
endpointSlice := &discoveryv1.EndpointSlice{}
369369
if err := helper.ConvertToTypedObject(unstructuredObj, endpointSlice); err != nil {
370-
klog.Errorf("Failed to convert unstructured object to typed object, error is: %v", err)
370+
klog.ErrorS(err, "Failed to convert unstructured object to typed object")
371371
return err
372372
}
373373

@@ -397,12 +397,12 @@ func (c *EndpointsliceDispatchController) ensureEndpointSliceWork(ctx context.Co
397397
}
398398
unstructuredEPS, err := helper.ToUnstructured(endpointSlice)
399399
if err != nil {
400-
klog.Errorf("Failed to convert typed object to unstructured object, error is: %v", err)
400+
klog.ErrorS(err, "Failed to convert typed object to unstructured object")
401401
return err
402402
}
403403
if err := ctrlutil.CreateOrUpdateWork(ctx, c.Client, workMeta, unstructuredEPS); err != nil {
404-
klog.Errorf("Failed to dispatch EndpointSlice %s/%s from %s to cluster %s:%v",
405-
work.GetNamespace(), work.GetName(), providerCluster, consumerCluster, err)
404+
klog.ErrorS(err, "Failed to dispatch EndpointSlice",
405+
"namespace", work.GetNamespace(), "name", work.GetName(), "providerCluster", providerCluster, "consumerCluster", consumerCluster)
406406
return err
407407
}
408408

@@ -414,13 +414,13 @@ func (c *EndpointsliceDispatchController) cleanupEndpointSliceFromConsumerCluste
414414
workList := &workv1alpha1.WorkList{}
415415
err := c.Client.List(ctx, workList)
416416
if err != nil {
417-
klog.Errorf("Failed to list works serror: %v", err)
417+
klog.ErrorS(err, "Failed to list works")
418418
return err
419419
}
420420

421421
epsSourceCluster, err := names.GetClusterName(work.Namespace)
422422
if err != nil {
423-
klog.Errorf("Failed to get EndpointSlice provider cluster name for work %s/%s", work.Namespace, work.Name)
423+
klog.ErrorS(err, "Failed to get EndpointSlice provider cluster name for work", "namespace", work.Namespace, "name", work.Name)
424424
return err
425425
}
426426
for _, item := range workList.Items {
@@ -434,7 +434,7 @@ func (c *EndpointsliceDispatchController) cleanupEndpointSliceFromConsumerCluste
434434

435435
if controllerutil.RemoveFinalizer(work, util.MCSEndpointSliceDispatchControllerFinalizer) {
436436
if err := c.Client.Update(ctx, work); err != nil {
437-
klog.Errorf("Failed to remove %s finalizer for work %s/%s:%v", util.MCSEndpointSliceDispatchControllerFinalizer, work.Namespace, work.Name, err)
437+
klog.ErrorS(err, "Failed to remove finalizer for work", "finalizer", util.MCSEndpointSliceDispatchControllerFinalizer, "namespace", work.Namespace, "name", work.Name)
438438
return err
439439
}
440440
}

0 commit comments

Comments
 (0)