added validation check for the components section of resourcebinding

Signed-off-by: Yifan Zhang <[email protected]>

Author: zclyne

api/openapi-spec/swagger.json

@@ -21216,12 +21216,14 @@
       "description": "Component represents the requirements for a specific component.",
       "type": "object",
       "required": [
+        "name",
         "replicas"
       ],
       "properties": {
         "name": {
           "description": "Name of this component. It is required when the resource contains multiple components to ensure proper identification, and must also be unique within the same resource.",
-          "type": "string"
+          "type": "string",
+          "default": ""
         },
         "replicaRequirements": {
           "description": "ReplicaRequirements represents the requirements required by each replica for this component.",

charts/karmada/_crds/bases/work/work.karmada.io_clusterresourcebindings.yaml

@@ -450,6 +450,7 @@ spec:
                       format: int32
                       type: integer
                   required:
+                  - name
                   - replicas
                   type: object
                 type: array

charts/karmada/_crds/bases/work/work.karmada.io_resourcebindings.yaml

@@ -450,6 +450,7 @@ spec:
                       format: int32
                       type: integer
                   required:
+                  - name
                   - replicas
                   type: object
                 type: array

pkg/apis/work/v1alpha2/binding_types.go

@@ -229,8 +229,8 @@ type Component struct {
 	// It is required when the resource contains multiple components to ensure proper identification,
 	// and must also be unique within the same resource.
 	// +kubebuilder:validation:MaxLength=32
-	// +optional
-	Name string `json:"name,omitempty"`
+	// +required
+	Name string `json:"name"`
 
 	// Replicas represents the replica number of the resource's component.
 	// +required

pkg/generated/openapi/zz_generated.openapi.go

@@ -26,6 +26,7 @@ import (
 	admissionv1 "k8s.io/api/admission/v1"
 	corev1 "k8s.io/api/core/v1"
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
+	"k8s.io/apimachinery/pkg/util/validation/field"
 	"k8s.io/client-go/util/retry"
 	"k8s.io/klog/v2"
 	"sigs.k8s.io/controller-runtime/pkg/client"
@@ -72,7 +73,12 @@ func (v *ValidatingAdmission) Handle(ctx context.Context, req admission.Request)
 		return admission.Denied(err.Error())
 	}
 
-	// further validation can be added here if needed
+	if features.FeatureGate.Enabled(features.MultiplePodTemplatesScheduling) {
+		if err := v.validateComponents(rb.Spec.Components, field.NewPath("spec").Child("components")); err != nil {
+			klog.Errorf("Admission denied for ResourceBinding %s/%s: %v", rb.Namespace, rb.Name, err)
+			return admission.Denied(err.Error())
+		}
+	}
 
 	return admission.Allowed("")
 }
@@ -324,6 +330,22 @@ func (v *ValidatingAdmission) processSingleFRQ(frqItem *policyv1alpha1.Federated
 	return potentialNewOverallUsedForThisFRQ, msg, nil
 }
 
+// validateComponents checks the validity of the Components field in the ResourceBinding.
+func (v *ValidatingAdmission) validateComponents(components []workv1alpha2.Component, fldPath *field.Path) error {
+	var allErrs field.ErrorList
+	componentNames := make(map[string]struct{})
+	for index, component := range components {
+		if len(component.Name) == 0 {
+			allErrs = append(allErrs, field.Invalid(fldPath.Index(index).Child("name"), component.Name, "component names must be non-empty"))
+		} else if _, exists := componentNames[component.Name]; exists {
+			allErrs = append(allErrs, field.Invalid(fldPath.Index(index).Child("name"), component.Name, "component names must be unique"))
+		} else {
+			componentNames[component.Name] = struct{}{}
+		}
+	}
+	return allErrs.ToAggregate()
+}
+
 func isQuotaRelevantFieldChanged(oldRB, newRB *workv1alpha2.ResourceBinding) bool {
 	if oldRB == nil || newRB == nil {
 		return true