From 46200919d8ec8b8ac6d744ac46fac549668ff23a Mon Sep 17 00:00:00 2001 From: Krishiv-Mahajan Date: Tue, 10 Mar 2026 16:48:50 +0530 Subject: [PATCH 1/3] fix: add curl fallback in deploy-k8s-metrics-server.sh for macOS compatibility Signed-off-by: Krishiv-Mahajan --- hack/deploy-k8s-metrics-server.sh | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/hack/deploy-k8s-metrics-server.sh b/hack/deploy-k8s-metrics-server.sh index d305c0c3fb22..6562ad71065d 100755 --- a/hack/deploy-k8s-metrics-server.sh +++ b/hack/deploy-k8s-metrics-server.sh @@ -53,7 +53,15 @@ fi MEMBER_CLUSTER_NAME=$2 # get deploy yaml -wget https://github.com/kubernetes-sigs/metrics-server/releases/download/v0.6.3/components.yaml -O "${_tmp}/components.yaml" +# Prefer curl (available on macOS + Linux); fall back to wget; fail with a clear error if neither exists +if command -v curl &>/dev/null; then + curl -fsSL https://github.com/kubernetes-sigs/metrics-server/releases/download/v0.6.3/components.yaml -o "${_tmp}/components.yaml" +elif command -v wget &>/dev/null; then + wget -qO "${_tmp}/components.yaml" https://github.com/kubernetes-sigs/metrics-server/releases/download/v0.6.3/components.yaml +else + echo "ERROR: neither curl nor wget found. Please install one of them and retry." + exit 1 +fi sed -i'' -e 's/args:/args:\n - --kubelet-insecure-tls=true/' "${_tmp}/components.yaml" # deploy metrics-server in member cluster From cdc40eee63cb9ff339d701214cad4ee24ce25230 Mon Sep 17 00:00:00 2001 From: Krishiv-Mahajan Date: Wed, 11 Mar 2026 13:58:01 +0530 Subject: [PATCH 2/3] adding a variable for server-url Signed-off-by: Krishiv-Mahajan --- hack/deploy-k8s-metrics-server.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hack/deploy-k8s-metrics-server.sh b/hack/deploy-k8s-metrics-server.sh index 6562ad71065d..1b9fa1c87f79 100755 --- a/hack/deploy-k8s-metrics-server.sh +++ b/hack/deploy-k8s-metrics-server.sh @@ -53,11 +53,12 @@ fi MEMBER_CLUSTER_NAME=$2 # get deploy yaml +METRICS_SERVER_URL="https://github.com/kubernetes-sigs/metrics-server/releases/download/v0.6.3/components.yaml" # Prefer curl (available on macOS + Linux); fall back to wget; fail with a clear error if neither exists if command -v curl &>/dev/null; then - curl -fsSL https://github.com/kubernetes-sigs/metrics-server/releases/download/v0.6.3/components.yaml -o "${_tmp}/components.yaml" + curl -fsSL "${METRICS_SERVER_URL}" -o "${_tmp}/components.yaml" elif command -v wget &>/dev/null; then - wget -qO "${_tmp}/components.yaml" https://github.com/kubernetes-sigs/metrics-server/releases/download/v0.6.3/components.yaml + wget -qO "${_tmp}/components.yaml" "${METRICS_SERVER_URL}" else echo "ERROR: neither curl nor wget found. Please install one of them and retry." exit 1 From 8d31c4643a2b4785a23939a176d1bd9d1268124f Mon Sep 17 00:00:00 2001 From: Krishiv-Mahajan Date: Mon, 16 Mar 2026 14:14:47 +0530 Subject: [PATCH 3/3] adding_proper_wget_fallback Signed-off-by: Krishiv-Mahajan --- hack/deploy-k8s-metrics-server.sh | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hack/deploy-k8s-metrics-server.sh b/hack/deploy-k8s-metrics-server.sh index 1b9fa1c87f79..1bffc2b0c58f 100755 --- a/hack/deploy-k8s-metrics-server.sh +++ b/hack/deploy-k8s-metrics-server.sh @@ -54,13 +54,13 @@ MEMBER_CLUSTER_NAME=$2 # get deploy yaml METRICS_SERVER_URL="https://github.com/kubernetes-sigs/metrics-server/releases/download/v0.6.3/components.yaml" -# Prefer curl (available on macOS + Linux); fall back to wget; fail with a clear error if neither exists -if command -v curl &>/dev/null; then - curl -fsSL "${METRICS_SERVER_URL}" -o "${_tmp}/components.yaml" -elif command -v wget &>/dev/null; then - wget -qO "${_tmp}/components.yaml" "${METRICS_SERVER_URL}" +# Prefer curl (available on macOS + Linux); fall back to wget on failure; fail with a clear error if both fail +if command -v curl &>/dev/null && curl -fsSL "${METRICS_SERVER_URL}" -o "${_tmp}/components.yaml"; then + : +elif command -v wget &>/dev/null && wget -qO "${_tmp}/components.yaml" "${METRICS_SERVER_URL}"; then + : else - echo "ERROR: neither curl nor wget found. Please install one of them and retry." + echo "ERROR: failed to download metrics-server components.yaml. Please ensure curl or wget is installed and network access is available." exit 1 fi sed -i'' -e 's/args:/args:\n - --kubelet-insecure-tls=true/' "${_tmp}/components.yaml"