Missing customs field in RateRequest serializer breaks international rate quotes #931
Closed
jacobshilitz
started this conversation in
General
Replies: 2 comments
-
|
see #932 |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Say no more. Thanks much, it was on my urgent backlog |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Problem
The
RateRequestserializer is missing thecustomsfield, causing all customs data to be silently dropped when clients send rate requests. This breaks international rate quotes that require customs information (duty, incoterm, HS codes, etc.).Root cause: The serializer doesn't accept
customs, even though:datatypes.RateRequest) includes itShipmentContentserializer already has itImpact
parcels[].itemsas a fallback, but this misses critical information like who is paying duties (duty.paid_by), incoterms, invoice details, and other customs metadata required for accurate rate quotesEvidence
Serializer missing customs:
modules/core/karrio/server/core/serializers.py:654But datatype has it:
modules/core/karrio/server/core/datatypes.py:195And ShipmentContent has it:
modules/core/karrio/server/core/serializers.py:1412Solution
Add
customsfield toRateRequestserializer:modules/core/karrio/server/core/serializers.py:734Why This Matters for Rating
International rate quotes require customs data to calculate:
dutypayment info andincoterm(DDP/DDU)Without the
customsfield, all this data is lost, resulting in inaccurate or incomplete rate quotes.Beta Was this translation helpful? Give feedback.
All reactions