Skip to content

Commit 282317a

Browse files
leezukarthink
authored andcommitted
gptel-bedrock: Bump curl version requirement
While Curl 8.5.0 supports --aws-sigv4 parameter, its implementation is buggy and versions prior to 8.9.0 trigger a "The request signature we calculated does not match the signature you provided. Check your AWS Secret Access Key and signing method." error when interacting with Bedrock. * NEWS (New models and backends): Update. * gptel-bedrock.el (gptel-make-bedrock): Update Curl check.
1 parent 391ab6c commit 282317a

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

NEWS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151

5252
- Add support for AWS Bedrock models. You can create an AWS Bedrock
5353
gptel backend with ~gptel-make-bedrock~, which see. Please note:
54-
AWS Bedrock support requires Curl 8.5.0 or higher.
54+
AWS Bedrock support requires Curl 8.9.0 or higher.
5555

5656
- You can now create an xAI backend with ~gptel-make-xai~, which see.
5757
(xAI was supported before but the model configuration is now handled

gptel-bedrock.el

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -617,8 +617,8 @@ MODEL-REGION - one of apac, eu, us or nil
617617
CURL-ARGS - additional curl args
618618
STREAM - Whether to use streaming responses or not."
619619
(declare (indent 1))
620-
(unless (and gptel-use-curl (version<= "8.5" (gptel-bedrock--curl-version)))
621-
(error "Bedrock-backend requires curl >= 8.5, but gptel-use-curl := %s, curl-version := %s"
620+
(unless (and gptel-use-curl (version<= "8.9" (gptel-bedrock--curl-version)))
621+
(error "Bedrock-backend requires curl >= 8.9, but gptel-use-curl := %s, curl-version := %s"
622622
gptel-use-curl (gptel-bedrock--curl-version)))
623623
(let ((host (format "bedrock-runtime.%s.amazonaws.com" region)))
624624
(setf (alist-get name gptel--known-backends nil nil #'equal)

0 commit comments

Comments
 (0)