routing: fix missing support for '+' notation of hostnames

Author: evenh

pkg/resourcegenerator/istio/virtualservice/routing.go

@@ -30,13 +30,18 @@ func generateForRouting(r reconciliation.Reconciliation) error {
 		},
 	}
 
+	h, err := routing.Spec.GetHost()
+	if err != nil || h == nil {
+		return fmt.Errorf("failed to get host from routing: %w", err)
+	}
+
 	virtualService.Spec = networkingv1api.VirtualService{
 		ExportTo: []string{".", "istio-system", "istio-gateways"},
 		Gateways: []string{
 			routing.GetGatewayName(),
 		},
 		Hosts: []string{
-			routing.Spec.Hostname,
+			h.Hostname,
 		},
 		Http: []*networkingv1api.HTTPRoute{},
 	}

tests/routing/custom-certificate/routing-assert.yaml

@@ -38,3 +38,34 @@ spec:
       tls:
         credentialName: some-cert
         mode: SIMPLE
+---
+apiVersion: networking.istio.io/v1
+kind: VirtualService
+metadata:
+  name: some-routing-routing-ingress
+spec:
+  exportTo:
+    - .
+    - istio-system
+    - istio-gateways
+  gateways:
+    - some-routing-routing-ingress
+  hosts:
+    - example.com
+  http:
+    - match:
+        - port: 80
+      name: redirect-to-https
+      redirect:
+        redirectCode: 308
+        scheme: https
+    - match:
+        - port: 443
+          uri:
+            prefix: /app1
+      name: some-app
+      route:
+        - destination:
+            host: some-app
+            port:
+              number: 8081