Add feature flag to enable locally built images.

Author: larsore

pkg/flags/flags.go

@@ -15,12 +15,14 @@ var FeatureFlags *Features
 type Features struct {
 	DisablePodTopologySpreadConstraints bool
 	EnableProfiling                     bool
+	EnableLocallyBuiltImages            bool
 }
 
 func init() {
 	FeatureFlags = &Features{
 		DisablePodTopologySpreadConstraints: getEnvWithFallback("DISABLE_PTSC", false),
 		EnableProfiling:                     getEnvWithFallback("ENABLE_PROFILING", false),
+		EnableLocallyBuiltImages:            getEnvWithFallback("ENABLE_LOCAL_IMAGES", false),
 	}
 }
 

pkg/resourcegenerator/deployment/deployment.go

@@ -3,6 +3,7 @@ package deployment
 import (
 	goerrors "errors"
 	"fmt"
+	"github.com/kartverket/skiperator/pkg/flags"
 	"strings"
 
 	"github.com/kartverket/skiperator/pkg/reconciliation"
@@ -215,13 +216,16 @@ func Generate(r reconciliation.Reconciliation) error {
 		deployment.Annotations[AnnotationKeyLinkPrefix] = fmt.Sprintf("https://%s", ingresses[0])
 	}
 
-	err = util.ResolveImageTags(r.GetCtx(), ctxLog.GetLogger(), r.GetRestConfig(), &deployment)
-	if err != nil {
-		//TODO fix this
-		// Exclude dummy image used in tests for decreased verbosity
-		if !strings.Contains(err.Error(), "https://index.docker.io/v2/library/image/manifests/latest") {
-			ctxLog.Error(err, "could not resolve container image to digest")
-			return err
+	// Global feature flag
+	if !flags.FeatureFlags.EnableLocallyBuiltImages {
+		err = util.ResolveImageTags(r.GetCtx(), ctxLog.GetLogger(), r.GetRestConfig(), &deployment)
+		if err != nil {
+			//TODO fix this
+			// Exclude dummy image used in tests for decreased verbosity
+			if !strings.Contains(err.Error(), "https://index.docker.io/v2/library/image/manifests/latest") {
+				ctxLog.Error(err, "could not resolve container image to digest")
+				return err
+			}
 		}
 	}
 

pkg/resourcegenerator/pod/pod.go

@@ -75,10 +75,17 @@ func CreatePodSpec(containers []corev1.Container, volumes []corev1.Volume, servi
 }
 
 func CreateApplicationContainer(application *skiperatorv1alpha1.Application, opts PodOpts) corev1.Container {
+	imagePullPolicy := func() corev1.PullPolicy {
+		if flags.FeatureFlags.EnableLocallyBuiltImages {
+			return corev1.PullNever
+		}
+		return corev1.PullAlways
+	}()
+
 	return corev1.Container{
 		Name:            application.Name,
 		Image:           application.Spec.Image,
-		ImagePullPolicy: corev1.PullAlways,
+		ImagePullPolicy: imagePullPolicy,
 		Command:         application.Spec.Command,
 		SecurityContext: &corev1.SecurityContext{
 			Privileged:               util.PointTo(false),