Rewrite estimate_network_hashes_per_second_impl #715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IzioDev
reviewed
Aug 9, 2025
| for chain_block in self.services.reachability_service.default_backward_chain_iterator(ghostdag_data.selected_parent) { | ||
| let gd = self.get_ghostdag_data(chain_block).unwrap(); | ||
| for red in &gd.mergeset_reds { | ||
| let red_header = self.headers_store.get_header(*red).unwrap(); |
Collaborator
There was a problem hiding this comment.
Is it safe to assume the header will be in the store for the whole rpc thread execution?
Is there a lock on the store?
edit: should be reasonable to assume the iterator won't go up until pruning point since the window is meant to be reasonable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.